[lldb] Run the test suite in verbose mode

[JDevlieghere]

Summary

Run check-lldb in verbose mode so that the bot shows which tests are unsupported.

https://llvm.discourse.group/t/lldb-buildbots-verbosity/5253

[stella.stamenova]

LGTM

[ljmf00]

zorg/buildbot/builders/LLDBBuilder.py

50–51

I don't know if ninja verbosity propagates to llvm-lit, but isn't this more appropriate in LLVM_LIT_ARGS cmake flag?

[ljmf00]

zorg/buildbot/builders/LLDBBuilder.py

50–51

See https://github.com/llvm/llvm-zorg/blob/main/zorg/buildbot/builders/ClangBuilder.py#L287 for reference.

[JDevlieghere]

Hey Galina,

Seems like this didn't take effect until the buildbots got rebooted, which
seems to have happened last night. Apparently my patch broke all the
buildbots because the jobs variable was not what I thought it was...

Anyway, I've removed the offending code
in 4d68a096efc7b5ad0d55cf64225962b9ba9ffed9. Would you mind restarting the
buildbots again so that can take effect?

Thanks,
Jonas

[gkistanova]

zorg/buildbot/builders/LLDBBuilder.py

72

To work as expected, this line should be wrapped in WithProperties either here, or each of the cmake_options items below before calling CmakeCommand.

And you do not need extra quotation marks around %s here, even if multiple options is specified for -DLLVM_LIT_ARGS.

[stella.stamenova]

Since @omjavaid is working on a related change in https://reviews.llvm.org/D117363, perhaps he can make the necessary changes there to support -j for the tests?

zorg/buildbot/builders/LLDBBuilder.py

if vs and vs != 'manual':
             command=getVisualStudioEnvironment(vs, target_arch),
             extract_fn=extractVSEnvironment))
         env = Property('vs_env')
 
     f.addGetSourcecodeSteps()
 
     build_cmd=['ninja']
     install_cmd = ['ninja','install']
     test_cmd = ['ninja','check-lldb']
+    lit_args = '-v'
 
     if jobs:
         build_cmd.append(WithProperties("-j%s" % jobs))
         install_cmd.append(WithProperties("-j%s" % jobs))
         test_cmd.append(WithProperties("-j%s" % jobs))
+        lit_args += " -j%s" % jobs
 
     ############# CLEANING
     cleanBuildRequested = lambda step: clean or step.build.getProperty("clean", default=step.build.getProperty("clean_obj"))
     f.addStep(steps.RemoveDirectory(name='clean '+build_dir,
                 dir=build_dir,
                 haltOnFailure=False,
                 flunkOnFailure=False,
                 doStepIf=cleanBuildRequested
                 ))
 
     rel_src_dir = LLVMBuildFactory.pathRelativeTo(f.llvm_srcdir, f.obj_dir)
     cmake_options = [
         "-G", "Ninja",
         "-DCMAKE_BUILD_TYPE=" + config,
+        "-DLLVM_LIT_ARGS='%s'" % lit_args,
         "-DCMAKE_INSTALL_PREFIX=../install",
         "-DLLVM_ENABLE_PROJECTS=%s" % ";".join(f.depends_on_projects),
         ]
     if python_source_dir:
         cmake_options.append("-DPYTHON_HOME=" + python_source_dir)
     if extra_cmake_args:
         cmake_options += extra_cmake_args