This is an archive of the discontinued LLVM Phabricator instance.

[mlir][NFC] Fully spell mlir typenames in BaseOpWithOffsetSizesAndStrides
ClosedPublic

Authored by Hardcode84 on Jan 10 2022, 9:07 AM.

Diff Detail

Event Timeline

Hardcode84 created this revision.Jan 10 2022, 9:07 AM
Hardcode84 requested review of this revision.Jan 10 2022, 9:07 AM
rriddle accepted this revision.Jan 10 2022, 9:42 AM

LGTM for fixing this, but I don't think this class should be in OpBase. Pinged on the original revision.

mlir/include/mlir/IR/OpBase.td
2478–2481

Can you wrap this at 80?

This revision is now accepted and ready to land.Jan 10 2022, 9:42 AM
Hardcode84 marked an inline comment as done.Jan 10 2022, 10:23 AM