This is an archive of the discontinued LLVM Phabricator instance.

[MLIR][NFC] Move presburger functionality from FlatAffineConstraints to IntegerPolyhedron
ClosedPublic

Authored by Groverkss on Jan 5 2022, 10:46 AM.

Details

Summary

This patch moves all presburger functionality from FlatAffineConstraints to
IntegerPolyhedron. This patch is purely mechanical, it only moves and renames
functionality and tests.

This patch is part of a series of patches to move presburger functionality to
Presburger/ directory.

Diff Detail

Event Timeline

Groverkss created this revision.Jan 5 2022, 10:46 AM
Groverkss requested review of this revision.Jan 5 2022, 10:46 AM

Seems good to me overall. I would wait for @bondhugula's feedback as well.

mlir/include/mlir/Analysis/AffineStructures.h
107–108

Can you explain why this is needed? Would also be helpful to have it in the documentation.

Groverkss updated this revision to Diff 397825.Jan 6 2022, 2:41 AM
Groverkss marked an inline comment as done.
  • Add doc comment for using IntegerPolyhedron::addBound
arjunp added inline comments.Jan 6 2022, 5:31 AM
mlir/include/mlir/Analysis/AffineStructures.h
107–108

I don't know if this long an explanation is unnecessary, and this is also a bit unspecific. You can just mention that the below overload for addBound hides the inherited overloads by default so we explicitly introduce them here. Maybe put the using declaration below that overload too, might be slightly easier to read that way

Groverkss updated this revision to Diff 397868.Jan 6 2022, 6:10 AM
Groverkss marked an inline comment as done.
  • Address Arjun's doc comment
bondhugula added a comment.EditedJan 6 2022, 7:15 AM

If this is a pure move and there is no change in functionality, can you mark the commit with an NFC? (policy: https://llvm.org/docs/DeveloperPolicy.html#obtaining-commit-access)

Groverkss retitled this revision from [MLIR] Move presburger functionality from FlatAffineConstraints to IntegerPolyhedron to [MLIR][NFC] Move presburger functionality from FlatAffineConstraints to IntegerPolyhedron.Jan 6 2022, 11:12 AM
bondhugula accepted this revision.Jan 7 2022, 9:17 AM
This revision is now accepted and ready to land.Jan 7 2022, 9:17 AM
mlir/lib/Analysis/Presburger/IntegerPolyhedron.cpp