Page MenuHomePhabricator

Define a `cppAccessorType` to const-ref in APFloatParameter and update ODS emitter to use it for verifier signatures
AcceptedPublic

Authored by mehdi_amini on Jan 2 2022, 3:47 PM.

Details

Summary

This reduce an unnecessary amount of copy of non-trivial objects, like
APFloat.

Diff Detail

Event Timeline

mehdi_amini created this revision.Jan 2 2022, 3:47 PM
mehdi_amini requested review of this revision.Jan 2 2022, 3:47 PM
rriddle accepted this revision.Jan 2 2022, 4:01 PM
This revision is now accepted and ready to land.Jan 2 2022, 4:01 PM
jpienaar accepted this revision.Jan 2 2022, 4:10 PM

Thanks!

This revision was landed with ongoing or failed builds.Jan 2 2022, 8:57 PM
This revision was automatically updated to reflect the committed changes.
mehdi_amini reopened this revision.Jan 2 2022, 10:41 PM

I reverted because of an issue with gcc5: https://buildkite.com/mlir/mlir-core/builds/19348#c0e75c4f-5350-47d0-a85a-2690aa4e01c6/362-550

Can't construct a tuple containing a std::string from a StringRef there...

Which made me look a bit more into the Key: shouldn't we use a StringRef in the Key as well instead of using the storage type?

This revision is now accepted and ready to land.Jan 2 2022, 10:41 PM