This is an archive of the discontinued LLVM Phabricator instance.

Differential D116274

[MLIR][LLVM] Add MemmoveOp to LLVM Dialect
ClosedPublic

Authored by wsmoses on Dec 24 2021, 1:54 PM.

Details

Reviewers
mehdi_amini
rriddle
ftynse
Commits
rG2709fd1520bc: [MLIR][LLVM] Add MemmoveOp to LLVM Dialect
Summary

LLVM Dialect in MLIR doesn't have a memmove op. This adds one.

Diff Detail

Event Timeline

wsmoses created this revision.Dec 24 2021, 1:54 PM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 18 others. · View Herald TranscriptDec 24 2021, 1:54 PM
wsmoses requested review of this revision.Dec 24 2021, 1:54 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 24 2021, 1:54 PM
Herald added subscribers: stephenneuendorffer, nicolasvasilache. · View Herald Transcript
wsmoses updated this revision to Diff 396182.Dec 24 2021, 1:59 PM

Correct name

mehdi_amini accepted this revision.Dec 24 2021, 4:24 PM

Can you mention in the title/description that this is an intrinsic?

This revision is now accepted and ready to land.Dec 24 2021, 4:24 PM
This revision was landed with ongoing or failed builds.Dec 24 2021, 4:48 PM
Closed by commit rG2709fd1520bc: [MLIR][LLVM] Add MemmoveOp to LLVM Dialect (authored by wsmoses). · Explain Why
This revision was automatically updated to reflect the committed changes.
wsmoses added a commit: rG2709fd1520bc: [MLIR][LLVM] Add MemmoveOp to LLVM Dialect.

Revision Contents

PathSize
mlir/
include/
mlir/
Dialect/
LLVMIR/
4 lines
test/
Target/
LLVMIR/
8 lines

Diff 396182

mlir/include/mlir/Dialect/LLVMIR/LLVMOps.td

Show First 20 Lines • Show All 1,441 Lines • ▼ Show 20 Lines
def LLVM_MemcpyOp : LLVM_ZeroResultIntrOp<"memcpy", [0, 1, 2]> { def LLVM_MemcpyOp : LLVM_ZeroResultIntrOp<"memcpy", [0, 1, 2]> {
let arguments = (ins LLVM_Type:$dst, LLVM_Type:$src, LLVM_Type:$len, let arguments = (ins LLVM_Type:$dst, LLVM_Type:$src, LLVM_Type:$len,
LLVM_Type:$isVolatile); LLVM_Type:$isVolatile);
} }
def LLVM_MemcpyInlineOp : LLVM_ZeroResultIntrOp<"memcpy.inline", [0, 1, 2]> { def LLVM_MemcpyInlineOp : LLVM_ZeroResultIntrOp<"memcpy.inline", [0, 1, 2]> {
let arguments = (ins LLVM_Type:$dst, LLVM_Type:$src, LLVM_Type:$len, let arguments = (ins LLVM_Type:$dst, LLVM_Type:$src, LLVM_Type:$len,
LLVM_Type:$isVolatile); LLVM_Type:$isVolatile);
} }
def LLVM_MemmoveOp : LLVM_ZeroResultIntrOp<"memmove", [0, 1, 2]> {
let arguments = (ins LLVM_Type:$dst, LLVM_Type:$src, LLVM_Type:$len,
LLVM_Type:$isVolatile);
}
def LLVM_MemsetOp : LLVM_ZeroResultIntrOp<"memset", [0, 2]> { def LLVM_MemsetOp : LLVM_ZeroResultIntrOp<"memset", [0, 2]> {
let arguments = (ins LLVM_Type:$dst, LLVM_Type:$val, LLVM_Type:$len, let arguments = (ins LLVM_Type:$dst, LLVM_Type:$val, LLVM_Type:$len,
LLVM_Type:$isVolatile); LLVM_Type:$isVolatile);
} }
// Intrinsics with multiple returns. // Intrinsics with multiple returns.
▲ Show 20 Lines • Show All 441 Lines • Show Last 20 Lines

mlir/test/Target/LLVMIR/llvmir-intrinsics.mlir

Show First 20 Lines • Show All 344 Lines • ▼ Show 20 Linesllvm.func @memcpy_test(%arg0: i32, %arg2: !llvm.ptr<i8>, %arg3: !llvm.ptr<i8>) {
// CHECK: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %{{.*}}, i8* %{{.*}}, i32 %{{.*}}, i1 {{.*}}) // CHECK: call void @llvm.memcpy.p0i8.p0i8.i32(i8* %{{.*}}, i8* %{{.*}}, i32 %{{.*}}, i1 {{.*}})
"llvm.intr.memcpy"(%arg2, %arg3, %arg0, %i1) : (!llvm.ptr<i8>, !llvm.ptr<i8>, i32, i1) -> () "llvm.intr.memcpy"(%arg2, %arg3, %arg0, %i1) : (!llvm.ptr<i8>, !llvm.ptr<i8>, i32, i1) -> ()
%sz = llvm.mlir.constant(10: i64) : i64 %sz = llvm.mlir.constant(10: i64) : i64
// CHECK: call void @llvm.memcpy.inline.p0i8.p0i8.i64(i8* %{{.*}}, i8* %{{.*}}, i64 10, i1 {{.*}}) // CHECK: call void @llvm.memcpy.inline.p0i8.p0i8.i64(i8* %{{.*}}, i8* %{{.*}}, i64 10, i1 {{.*}})
"llvm.intr.memcpy.inline"(%arg2, %arg3, %sz, %i1) : (!llvm.ptr<i8>, !llvm.ptr<i8>, i64, i1) -> () "llvm.intr.memcpy.inline"(%arg2, %arg3, %sz, %i1) : (!llvm.ptr<i8>, !llvm.ptr<i8>, i64, i1) -> ()
llvm.return llvm.return
} }
// CHECK-LABEL: @memmove_test
llvm.func @memmove_test(%arg0: i32, %arg2: !llvm.ptr<i8>, %arg3: !llvm.ptr<i8>) {
%i1 = llvm.mlir.constant(false) : i1
// CHECK: call void @llvm.memmove.p0i8.p0i8.i32(i8* %{{.*}}, i8* %{{.*}}, i32 %{{.*}}, i1 {{.*}})
"llvm.intr.memmove"(%arg2, %arg3, %arg0, %i1) : (!llvm.ptr<i8>, !llvm.ptr<i8>, i32, i1) -> ()
llvm.return
}
// CHECK-LABEL: @memset_test // CHECK-LABEL: @memset_test
llvm.func @memset_test(%arg0: i32, %arg2: !llvm.ptr<i8>, %arg3: i8) { llvm.func @memset_test(%arg0: i32, %arg2: !llvm.ptr<i8>, %arg3: i8) {
%i1 = llvm.mlir.constant(false) : i1 %i1 = llvm.mlir.constant(false) : i1
// CHECK: call void @llvm.memset.p0i8.i32(i8* %{{.*}}, i8 %{{.*}}, i32 %{{.*}}, i1 {{.*}}) // CHECK: call void @llvm.memset.p0i8.i32(i8* %{{.*}}, i8 %{{.*}}, i32 %{{.*}}, i1 {{.*}})
"llvm.intr.memset"(%arg2, %arg3, %arg0, %i1) : (!llvm.ptr<i8>, i8, i32, i1) -> () "llvm.intr.memset"(%arg2, %arg3, %arg0, %i1) : (!llvm.ptr<i8>, i8, i32, i1) -> ()
llvm.return llvm.return
} }
▲ Show 20 Lines • Show All 188 Lines • Show Last 20 Lines