Page MenuHomePhabricator

[mlir][arith] Fix CmpIOP folding for vector types.
ClosedPublic

Authored by akuegel on Dec 22 2021, 2:44 AM.

Details

Summary

It failed for vector types before, but now it folds them correctly.

Diff Detail

Event Timeline

akuegel created this revision.Dec 22 2021, 2:44 AM
akuegel requested review of this revision.Dec 22 2021, 2:44 AM
herhut accepted this revision.Dec 22 2021, 6:39 AM

Thanks!

This revision is now accepted and ready to land.Dec 22 2021, 6:39 AM

Can you change the subject to have an additional tag, e.g., [mlir][arith]. That provides a little more context. You could also state that it did fail for vectors before but now it folds them correctly.

LGTM. Just a comment about the test.

mlir/test/Dialect/Arithmetic/canonicalize.mlir
22

Is the issue only with ugt? Would it make sense to keep this test as is and then copy this test and use a vector type for all the predicates instead?

akuegel updated this revision to Diff 395886.Dec 22 2021, 9:05 AM

Address review comment (improve test).

akuegel retitled this revision from [mlir] Fix CmpIOP folding for vector types. to [mlir][arith] Fix CmpIOP folding for vector types..Dec 22 2021, 9:06 AM
akuegel edited the summary of this revision. (Show Details)
akuegel updated this revision to Diff 395887.Dec 22 2021, 9:10 AM

Simplify test.

Can you change the subject to have an additional tag, e.g., [mlir][arith]. That provides a little more context. You could also state that it did fail for vectors before but now it folds them correctly.

Done.

mlir/test/Dialect/Arithmetic/canonicalize.mlir
22

You are right, it is better to copy the whole test. Done.

This revision was landed with ongoing or failed builds.Dec 22 2021, 9:12 AM
This revision was automatically updated to reflect the committed changes.