This is an archive of the discontinued LLVM Phabricator instance.

[Coroutine] Remove the '!func_sanitize' metadata for split functions
ClosedPublic

Authored by ychen on Dec 21 2021, 2:01 PM.

Details

Summary

There is no proper RTTI for these split functions. So just delete the
metadata.

Fixes PR50345.

Diff Detail

Event Timeline

ychen created this revision.Dec 21 2021, 2:01 PM
ychen requested review of this revision.Dec 21 2021, 2:01 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 21 2021, 2:01 PM
ChuanqiXu added inline comments.Dec 21 2021, 5:55 PM
llvm/lib/Transforms/Coroutines/CoroSplit.cpp
923–925

How about adding comments for this? I guess people might be confused.

ychen updated this revision to Diff 395788.Dec 21 2021, 7:33 PM
  • Add comments.
ychen marked an inline comment as done.Dec 21 2021, 7:33 PM
ychen added inline comments.
llvm/lib/Transforms/Coroutines/CoroSplit.cpp
923–925

Yep. Comments added.

rjmccall accepted this revision.Dec 21 2021, 8:11 PM

LGTM.

This revision is now accepted and ready to land.Dec 21 2021, 8:11 PM
ychen updated this revision to Diff 440342.Jun 27 2022, 11:50 AM
ychen marked an inline comment as done.

rebase

Herald added a project: Restricted Project. · View Herald TranscriptJun 27 2022, 11:50 AM