I missed the async info parameter in the first version of this API.
Details
Details
Diff Detail
Diff Detail
Event Timeline
Comment Actions
LG. Bit surprised the previous version built cleanly, extern C function type different to header should have been rejected
openmp/libomptarget/plugins/amdgpu/src/rtl.cpp | ||
---|---|---|
2289 | Ah, that's why. No extern C here so no error checking, just defined an unrelated function |
Comment Actions
It looks like https://reviews.llvm.org/D115823 will take a bit longer to be merged. I will merge this in to fix the API error, as it can go in first.
Comment Actions
Yep, I need to revise that patch. Don't like how easy it is to misspell or mistype these functions, going to look for a fix for that
Ah, that's why. No extern C here so no error checking, just defined an unrelated function