This is an archive of the discontinued LLVM Phabricator instance.

Differential D115799

[clangd] Add ) to signature-help triggers
ClosedPublic

Authored by kadircet on Dec 15 2021, 5:47 AM.

Details

Reviewers
sammccall
Commits
rG517f1d9e5cd0: [clangd] Add ) to signature-help triggers
Summary

It is important for nested function calls.

Diff Detail

Event Timeline

kadircet created this revision.Dec 15 2021, 5:47 AM
Herald added subscribers: usaxena95, arphaman. · View Herald TranscriptDec 15 2021, 5:47 AM
kadircet requested review of this revision.Dec 15 2021, 5:47 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 15 2021, 5:47 AM
Herald added subscribers: cfe-commits, MaskRay, ilya-biryukov. · View Herald Transcript
kadircet added a reviewer: sammccall.Dec 15 2021, 5:52 AM
sammccall accepted this revision.Dec 15 2021, 5:53 AM
This revision is now accepted and ready to land.Dec 15 2021, 5:53 AM
This revision was landed with ongoing or failed builds.Dec 15 2021, 5:57 AM
Closed by commit rG517f1d9e5cd0: [clangd] Add ) to signature-help triggers (authored by kadircet). · Explain Why
This revision was automatically updated to reflect the committed changes.
kadircet added a commit: rG517f1d9e5cd0: [clangd] Add ) to signature-help triggers.
Harbormaster completed remote builds in B139419: Diff 394539.Dec 15 2021, 6:01 AM

Revision Contents

PathSize
clang-tools-extra/
clangd/
2 lines
test/
3 lines

Diff 394541

clang-tools-extra/clangd/ClangdLSPServer.cpp

Show First 20 Lines • Show All 549 Lines • ▼ Show 20 Lines llvm::json::Object ServerCaps{
{"full", llvm::json::Object{{"delta", true}}}, {"full", llvm::json::Object{{"delta", true}}},
{"range", false}, {"range", false},
{"legend", {"legend",
llvm::json::Object{{"tokenTypes", semanticTokenTypes()}, llvm::json::Object{{"tokenTypes", semanticTokenTypes()},
{"tokenModifiers", semanticTokenModifiers()}}}, {"tokenModifiers", semanticTokenModifiers()}}},
}}, }},
{"signatureHelpProvider", {"signatureHelpProvider",
llvm::json::Object{ llvm::json::Object{
{"triggerCharacters", {"(", ","}}, {"triggerCharacters", {"(", ",", ")"}},
}}, }},
{"declarationProvider", true}, {"declarationProvider", true},
{"definitionProvider", true}, {"definitionProvider", true},
{"implementationProvider", true}, {"implementationProvider", true},
{"documentHighlightProvider", true}, {"documentHighlightProvider", true},
{"documentLinkProvider", {"documentLinkProvider",
llvm::json::Object{ llvm::json::Object{
{"resolveProvider", false}, {"resolveProvider", false},
▲ Show 20 Lines • Show All 1,122 Lines • Show Last 20 Lines

clang-tools-extra/clangd/test/initialize-params.test

Show First 20 Lines • Show All 101 Lines • ▼ Show 20 Lines
# CHECK-NEXT: "variable", # CHECK-NEXT: "variable",
# CHECK: ] # CHECK: ]
# CHECK-NEXT: }, # CHECK-NEXT: },
# CHECK-NEXT: "range": false # CHECK-NEXT: "range": false
# CHECK-NEXT: }, # CHECK-NEXT: },
# CHECK-NEXT: "signatureHelpProvider": { # CHECK-NEXT: "signatureHelpProvider": {
# CHECK-NEXT: "triggerCharacters": [ # CHECK-NEXT: "triggerCharacters": [
# CHECK-NEXT: "(", # CHECK-NEXT: "(",
# CHECK-NEXT: "," # CHECK-NEXT: ",",
# CHECK-NEXT: ")"
# CHECK-NEXT: ] # CHECK-NEXT: ]
# CHECK-NEXT: }, # CHECK-NEXT: },
# CHECK-NEXT: "textDocumentSync": { # CHECK-NEXT: "textDocumentSync": {
# CHECK-NEXT: "change": 2, # CHECK-NEXT: "change": 2,
# CHECK-NEXT: "openClose": true, # CHECK-NEXT: "openClose": true,
# CHECK-NEXT: "save": true # CHECK-NEXT: "save": true
# CHECK-NEXT: }, # CHECK-NEXT: },
# CHECK-NEXT: "typeHierarchyProvider": true # CHECK-NEXT: "typeHierarchyProvider": true
Show All 14 Lines