This is an archive of the discontinued LLVM Phabricator instance.

Differential D115717

[libcxx][test][NFC] noexcept tests for std::array
ClosedPublic

Authored by kboyarinov on Dec 14 2021, 2:31 AM.

Details

Reviewers
rarutyun
ldionne
zoecarver
Mordante
• Quuxplusone
Group Reviewers
Restricted Project
Commits
rGff94bd1bc92e: [libcxx][test][NFC] noexcept tests for std::array
Summary

Minor change - add tests that std::array methods (data, (c/r)begin, (c/r)end) are noexcept

Diff Detail

Event Timeline

kboyarinov requested review of this revision.Dec 14 2021, 2:31 AM
kboyarinov created this revision.
Harbormaster completed remote builds in B139192: Diff 394192.Dec 14 2021, 2:58 AM
ldionne accepted this revision.Dec 14 2021, 5:58 AM
ldionne added inline comments.
libcxx/test/std/containers/sequences/array/iterators.pass.cpp
47
This revision is now accepted and ready to land.Dec 14 2021, 5:58 AM
kboyarinov updated this revision to Diff 395110.Dec 17 2021, 6:06 AM

Fix unused variable in check_noexcept

kboyarinov marked an inline comment as done.Dec 17 2021, 6:38 AM
Harbormaster completed remote builds in B139833: Diff 395110.Dec 17 2021, 7:19 AM
ldionne accepted this revision.Dec 17 2021, 7:39 AM
rarutyun accepted this revision.Dec 18 2021, 4:56 AM
Closed by commit rGff94bd1bc92e: [libcxx][test][NFC] noexcept tests for std::array (authored by kboyarinov, committed by rarutyun). · Explain WhyDec 18 2021, 5:14 AM
This revision was automatically updated to reflect the committed changes.
rarutyun added a commit: rGff94bd1bc92e: [libcxx][test][NFC] noexcept tests for std::array.
Herald added a subscriber: libcxx-commits. · View Herald TranscriptDec 18 2021, 5:14 AM

Revision Contents

PathSize
libcxx/
test/
std/
containers/
sequences/
array/
array.data/
4 lines
3 lines
26 lines

Diff 395285

libcxx/test/std/containers/sequences/array/array.data/data.pass.cpp

Show All 29 Lines
#endif #endif
TEST_CONSTEXPR_CXX17 bool tests() TEST_CONSTEXPR_CXX17 bool tests()
{ {
{ {
typedef double T; typedef double T;
typedef std::array<T, 3> C; typedef std::array<T, 3> C;
C c = {1, 2, 3.5}; C c = {1, 2, 3.5};
ASSERT_NOEXCEPT(c.data());
T* p = c.data(); T* p = c.data();
assert(p[0] == 1); assert(p[0] == 1);
assert(p[1] == 2); assert(p[1] == 2);
assert(p[2] == 3.5); assert(p[2] == 3.5);
} }
{ {
typedef double T; typedef double T;
typedef std::array<T, 0> C; typedef std::array<T, 0> C;
C c = {}; C c = {};
ASSERT_NOEXCEPT(c.data());
T* p = c.data(); T* p = c.data();
(void)p; (void)p;
} }
{ {
typedef double T; typedef double T;
typedef std::array<const T, 0> C; typedef std::array<const T, 0> C;
C c = {{}}; C c = {{}};
ASSERT_NOEXCEPT(c.data());
const T* p = c.data(); const T* p = c.data();
(void)p; (void)p;
static_assert((std::is_same<decltype(c.data()), const T*>::value), ""); static_assert((std::is_same<decltype(c.data()), const T*>::value), "");
} }
{ {
typedef NoDefault T; typedef NoDefault T;
typedef std::array<T, 0> C; typedef std::array<T, 0> C;
C c = {}; C c = {};
ASSERT_NOEXCEPT(c.data());
T* p = c.data(); T* p = c.data();
(void)p; (void)p;
} }
{ {
std::array<int, 5> c = {0, 1, 2, 3, 4}; std::array<int, 5> c = {0, 1, 2, 3, 4};
assert(c.data() == &c[0]); assert(c.data() == &c[0]);
assert(*c.data() == c[0]); assert(*c.data() == c[0]);
} }
Show All 26 Lines

libcxx/test/std/containers/sequences/array/array.data/data_const.pass.cpp

Show All 29 Lines
#endif #endif
TEST_CONSTEXPR_CXX17 bool tests() TEST_CONSTEXPR_CXX17 bool tests()
{ {
{ {
typedef double T; typedef double T;
typedef std::array<T, 3> C; typedef std::array<T, 3> C;
const C c = {1, 2, 3.5}; const C c = {1, 2, 3.5};
ASSERT_NOEXCEPT(c.data());
const T* p = c.data(); const T* p = c.data();
assert(p[0] == 1); assert(p[0] == 1);
assert(p[1] == 2); assert(p[1] == 2);
assert(p[2] == 3.5); assert(p[2] == 3.5);
} }
{ {
typedef double T; typedef double T;
typedef std::array<T, 0> C; typedef std::array<T, 0> C;
const C c = {}; const C c = {};
ASSERT_NOEXCEPT(c.data());
const T* p = c.data(); const T* p = c.data();
(void)p; (void)p;
} }
{ {
typedef NoDefault T; typedef NoDefault T;
typedef std::array<T, 0> C; typedef std::array<T, 0> C;
const C c = {}; const C c = {};
ASSERT_NOEXCEPT(c.data());
const T* p = c.data(); const T* p = c.data();
(void)p; (void)p;
} }
{ {
std::array<int, 5> const c = {0, 1, 2, 3, 4}; std::array<int, 5> const c = {0, 1, 2, 3, 4};
assert(c.data() == &c[0]); assert(c.data() == &c[0]);
assert(*c.data() == c[0]); assert(*c.data() == c[0]);
} }
Show All 27 Lines

libcxx/test/std/containers/sequences/array/iterators.pass.cpp

Show All 27 Lines
#include <cassert> #include <cassert>
#include "test_macros.h" #include "test_macros.h"
struct NoDefault { struct NoDefault {
TEST_CONSTEXPR NoDefault(int) { } TEST_CONSTEXPR NoDefault(int) { }
}; };
template <class T>
TEST_CONSTEXPR_CXX17 void check_noexcept(T& c) {
ASSERT_NOEXCEPT(c.begin());
ASSERT_NOEXCEPT(c.end());
ASSERT_NOEXCEPT(c.cbegin());
ASSERT_NOEXCEPT(c.cend());
ASSERT_NOEXCEPT(c.rbegin());
ASSERT_NOEXCEPT(c.rend());
ASSERT_NOEXCEPT(c.crbegin());
ASSERT_NOEXCEPT(c.crend());
const T& cc = c; (void)cc;
ldionneUnsubmitted
Done
ReplyInline Actions
ASSERT_NOEXCEPT(c.crend());
- const T& cc = c;
+ const T& cc = c; (void)cc;
ASSERT_NOEXCEPT(cc.begin());
ldionne:
ASSERT_NOEXCEPT(cc.begin());
ASSERT_NOEXCEPT(cc.end());
ASSERT_NOEXCEPT(cc.rbegin());
ASSERT_NOEXCEPT(cc.rend());
}
TEST_CONSTEXPR_CXX17 bool tests() TEST_CONSTEXPR_CXX17 bool tests()
{ {
{ {
typedef std::array<int, 5> C; typedef std::array<int, 5> C;
C array = {}; C array = {};
check_noexcept(array);
typename C::iterator i = array.begin(); typename C::iterator i = array.begin();
typename C::const_iterator j = array.cbegin(); typename C::const_iterator j = array.cbegin();
assert(i == j); assert(i == j);
} }
{ {
typedef std::array<int, 0> C; typedef std::array<int, 0> C;
C array = {}; C array = {};
check_noexcept(array);
typename C::iterator i = array.begin(); typename C::iterator i = array.begin();
typename C::const_iterator j = array.cbegin(); typename C::const_iterator j = array.cbegin();
assert(i == j); assert(i == j);
} }
{ {
typedef std::array<int, 0> C; typedef std::array<int, 0> C;
C array = {}; C array = {};
check_noexcept(array);
typename C::iterator i = array.begin(); typename C::iterator i = array.begin();
typename C::const_iterator j = array.cbegin(); typename C::const_iterator j = array.cbegin();
assert(i == array.end()); assert(i == array.end());
assert(j == array.cend()); assert(j == array.cend());
} }
{ {
typedef std::array<int, 1> C; typedef std::array<int, 1> C;
C array = {1}; C array = {1};
check_noexcept(array);
typename C::iterator i = array.begin(); typename C::iterator i = array.begin();
assert(*i == 1); assert(*i == 1);
assert(&*i == array.data()); assert(&*i == array.data());
*i = 99; *i = 99;
assert(array[0] == 99); assert(array[0] == 99);
} }
{ {
typedef std::array<int, 2> C; typedef std::array<int, 2> C;
C array = {1, 2}; C array = {1, 2};
check_noexcept(array);
typename C::iterator i = array.begin(); typename C::iterator i = array.begin();
assert(*i == 1); assert(*i == 1);
assert(&*i == array.data()); assert(&*i == array.data());
*i = 99; *i = 99;
assert(array[0] == 99); assert(array[0] == 99);
assert(array[1] == 2); assert(array[1] == 2);
} }
{ {
typedef std::array<double, 3> C; typedef std::array<double, 3> C;
C array = {1, 2, 3.5}; C array = {1, 2, 3.5};
check_noexcept(array);
typename C::iterator i = array.begin(); typename C::iterator i = array.begin();
assert(*i == 1); assert(*i == 1);
assert(&*i == array.data()); assert(&*i == array.data());
*i = 5.5; *i = 5.5;
assert(array[0] == 5.5); assert(array[0] == 5.5);
assert(array[1] == 2.0); assert(array[1] == 2.0);
} }
{ {
Show All 14 Lines#if TEST_STD_VER >= 14
assert(ii1 == ii2); assert(ii1 == ii2);
assert(ii1 == ii4); assert(ii1 == ii4);
assert(ii1 == cii); assert(ii1 == cii);
assert(!(ii1 != ii2)); assert(!(ii1 != ii2));
assert(!(ii1 != cii)); assert(!(ii1 != cii));
C c = {}; C c = {};
check_noexcept(c);
assert(c.begin() == std::begin(c)); assert(c.begin() == std::begin(c));
assert(c.cbegin() == std::cbegin(c)); assert(c.cbegin() == std::cbegin(c));
assert(c.rbegin() == std::rbegin(c)); assert(c.rbegin() == std::rbegin(c));
assert(c.crbegin() == std::crbegin(c)); assert(c.crbegin() == std::crbegin(c));
assert(c.end() == std::end(c)); assert(c.end() == std::end(c));
assert(c.cend() == std::cend(c)); assert(c.cend() == std::cend(c));
assert(c.rend() == std::rend(c)); assert(c.rend() == std::rend(c));
assert(c.crend() == std::crend(c)); assert(c.crend() == std::crend(c));
Show All 24 Lines#if TEST_STD_VER >= 14
assert(!(ii1 > cii)); assert(!(ii1 > cii));
assert(!(cii > ii1)); assert(!(cii > ii1));
assert( (ii1 >= cii)); assert( (ii1 >= cii));
assert( (cii >= ii1)); assert( (cii >= ii1));
assert(cii - ii1 == 0); assert(cii - ii1 == 0);
assert(ii1 - cii == 0); assert(ii1 - cii == 0);
C c = {}; C c = {};
check_noexcept(c);
assert(c.begin() == std::begin(c)); assert(c.begin() == std::begin(c));
assert(c.cbegin() == std::cbegin(c)); assert(c.cbegin() == std::cbegin(c));
assert(c.rbegin() == std::rbegin(c)); assert(c.rbegin() == std::rbegin(c));
assert(c.crbegin() == std::crbegin(c)); assert(c.crbegin() == std::crbegin(c));
assert(c.end() == std::end(c)); assert(c.end() == std::end(c));
assert(c.cend() == std::cend(c)); assert(c.cend() == std::cend(c));
assert(c.rend() == std::rend(c)); assert(c.rend() == std::rend(c));
assert(c.crend() == std::crend(c)); assert(c.crend() == std::crend(c));
Show All 19 Lines