Page MenuHomePhabricator

kboyarinov (Konstantin Boyarinov)
User

Projects

User does not belong to any projects.

User Details

User Since
Jun 3 2021, 8:06 AM (78 w, 3 d)

Recent Activity

Feb 14 2022

kboyarinov requested review of D119703: [libcxx][test][NFC] Add tests for hash_function() and key_eq() in unordered containers.
Feb 14 2022, 2:58 AM · Restricted Project, Restricted Project

Feb 9 2022

kboyarinov updated the diff for D119236: [libcxx][test][NFC] Add tests for constructors of unordered [multi]map added in C++14.

Apply comments from D119243 (also applicable for this PR)

Feb 9 2022, 3:15 AM · Restricted Project, Restricted Project
kboyarinov added a comment to D119243: [libcxx][test][NFC] Add tests for C++14 constructors of unordered sets.

I have renamed tests that accept a pair of iterators: "range_*"->"iter_iter_*" for all such tests for sets

Feb 9 2022, 2:57 AM · Restricted Project, Restricted Project
kboyarinov updated the diff for D119243: [libcxx][test][NFC] Add tests for C++14 constructors of unordered sets.

Applying comments

Feb 9 2022, 2:53 AM · Restricted Project, Restricted Project

Feb 8 2022

kboyarinov requested review of D119243: [libcxx][test][NFC] Add tests for C++14 constructors of unordered sets.
Feb 8 2022, 7:01 AM · Restricted Project, Restricted Project
kboyarinov updated the diff for D119236: [libcxx][test][NFC] Add tests for constructors of unordered [multi]map added in C++14.

Exclude C++03 and C++11 from testing

Feb 8 2022, 6:58 AM · Restricted Project, Restricted Project
kboyarinov requested review of D119236: [libcxx][test][NFC] Add tests for constructors of unordered [multi]map added in C++14.
Feb 8 2022, 5:32 AM · Restricted Project, Restricted Project

Jan 31 2022

kboyarinov updated the diff for D118114: [libcxx][test][NFC] Add tests for backward iteration over associative containers.

Add assert(i == end()) and rename variables for consistency

Jan 31 2022, 7:13 AM · Restricted Project

Jan 26 2022

kboyarinov added inline comments to D118232: [libcxx][test][NFC] Rewrite map count test and add test case for "final" compare.
Jan 26 2022, 3:19 AM · Restricted Project, Restricted Project
kboyarinov updated the diff for D118114: [libcxx][test][NFC] Add tests for backward iteration over associative containers.

Remove test-case for the comparator marked final (moved to D118232)

Jan 26 2022, 3:18 AM · Restricted Project
kboyarinov requested review of D118232: [libcxx][test][NFC] Rewrite map count test and add test case for "final" compare.
Jan 26 2022, 3:11 AM · Restricted Project, Restricted Project

Jan 25 2022

kboyarinov added inline comments to D118114: [libcxx][test][NFC] Add tests for backward iteration over associative containers.
Jan 25 2022, 2:20 AM · Restricted Project
kboyarinov requested review of D118114: [libcxx][test][NFC] Add tests for backward iteration over associative containers.
Jan 25 2022, 2:09 AM · Restricted Project

Dec 17 2021

kboyarinov updated the diff for D115717: [libcxx][test][NFC] noexcept tests for std::array.

Fix unused variable in check_noexcept

Dec 17 2021, 6:06 AM · Restricted Project

Dec 14 2021

kboyarinov requested review of D115717: [libcxx][test][NFC] noexcept tests for std::array.
Dec 14 2021, 2:31 AM · Restricted Project

Dec 6 2021

kboyarinov updated the diff for D114954: [libcxx][test][NFC] Extend testing for vector.cons.

Fix comments from @ldionne

Dec 6 2021, 7:05 AM · Restricted Project
kboyarinov retitled D115136: [libcxx][test][NFC] Tests for sets comparisons from [libcxx][test][NFC] Tests for std::set comparisons to [libcxx][test][NFC] Tests for sets comparisons.
Dec 6 2021, 12:46 AM · Restricted Project
kboyarinov requested review of D115136: [libcxx][test][NFC] Tests for sets comparisons.
Dec 6 2021, 12:46 AM · Restricted Project

Dec 2 2021

kboyarinov requested review of D114954: [libcxx][test][NFC] Extend testing for vector.cons.
Dec 2 2021, 6:34 AM · Restricted Project

Dec 1 2021

kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Changed reverse_iterators.pass.cpp to use int n = 10 instead of n in all places

Dec 1 2021, 5:09 AM · Restricted Project

Nov 30 2021

kboyarinov added inline comments to D114785: [libcxx][test][NFC] Extend get_allocator() testing for containers.
Nov 30 2021, 5:17 AM · Restricted Project
kboyarinov updated the diff for D114785: [libcxx][test][NFC] Extend get_allocator() testing for containers.

Added type aliases for associative containers value_types.
Removed C++11 mode for other_allocator
Fixed C++03

Nov 30 2021, 5:15 AM · Restricted Project
kboyarinov requested review of D114785: [libcxx][test][NFC] Extend get_allocator() testing for containers.
Nov 30 2021, 3:01 AM · Restricted Project

Nov 29 2021

kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Fix comments by @rarutyun

Nov 29 2021, 1:23 AM · Restricted Project

Nov 23 2021

kboyarinov added a comment to D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp.

I did find some tests in libcxx/test/std/containers/associative/multiset/multiset.cons/compare.pass.cpp (and similarly for other container types). Could we incorporate the existing tests into yours and delete the old ones? IMO your new tests are more complete, the only thing I would do is use test_less like in the original ones.

I am not sure that we can just remove the test compare.pass.cpp, because it is intended to test std::map(const key_compare&) constructor and uses std::map::key_comp to test the constructor effect. New test is for std::map::key_comp effects. I agree that these tests are connected, but I do not think they are interchangeable. What do you think?

Oh my, you are right, I looked too quickly and missed that we were testing the constructors. In those constructor tests, can you please remove the part of the comment that looks like:

// key_compare    key_comp() const;
// value_compare value_comp() const;

This confused me into thinking we were testing those methods there, instead of just the constructor (which is explained by the comment immediately above):

// explicit multiset(const value_compare& comp);
// value_compare and key_compare are the same type for set/multiset

LGTM with my suggested comment cleanup to the existing constructor tests.

Nov 23 2021, 2:47 AM · Restricted Project
kboyarinov updated the diff for D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp.

Clean-up for comments in compare.pass.cpp test for all associative containers

Nov 23 2021, 2:45 AM · Restricted Project

Nov 22 2021

kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Removed the constructor of MaybePOCCAAllocator from int argument

Nov 22 2021, 12:48 PM · Restricted Project
kboyarinov added inline comments to D112438: [libcxx][test][NFC] Various tests for std::vector.
Nov 22 2021, 12:05 PM · Restricted Project
kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Removed static bool variable, renamed POCCAAllocator, added aliases

Nov 22 2021, 12:02 PM · Restricted Project
kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

A1 and A3 class templates from allocator.h cannot be used to test propagate_on_container_copy_assignment option during the vector::operator=(const vector&).
I have tried to change allocate and deallocate methods in these allocators to use new-delete to provide the real memory, but tests for std::scoped_allocator_adaptor has failed.
I have introduced the new class POCCAAllocator<T, bool> to test the behavior of vector on copy assignment.
Tests for other containers can also be rewritten to use the new allocator class.

Nov 22 2021, 7:59 AM · Restricted Project
kboyarinov added inline comments to D112438: [libcxx][test][NFC] Various tests for std::vector.
Nov 22 2021, 2:24 AM · Restricted Project
kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Fix comments from the last revision of the review

Nov 22 2021, 2:16 AM · Restricted Project

Nov 17 2021

kboyarinov added inline comments to D112438: [libcxx][test][NFC] Various tests for std::vector.
Nov 17 2021, 10:21 PM · Restricted Project
kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Renaming value to lvalue for insert_iter_lvalue.pass.cpp

Nov 17 2021, 10:19 PM · Restricted Project
kboyarinov updated the diff for D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp.

Fix CI, add return 0 where missed

Nov 17 2021, 3:26 AM · Restricted Project
kboyarinov added a comment to D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp.

I did find some tests in libcxx/test/std/containers/associative/multiset/multiset.cons/compare.pass.cpp (and similarly for other container types). Could we incorporate the existing tests into yours and delete the old ones? IMO your new tests are more complete, the only thing I would do is use test_less like in the original ones.

Nov 17 2021, 1:18 AM · Restricted Project
kboyarinov added inline comments to D112438: [libcxx][test][NFC] Various tests for std::vector.
Nov 17 2021, 12:24 AM · Restricted Project
kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Fix comments from differential review

Nov 17 2021, 12:15 AM · Restricted Project

Nov 16 2021

kboyarinov updated the diff for D112438: [libcxx][test][NFC] Various tests for std::vector.

Fix C++03

Nov 16 2021, 7:40 AM · Restricted Project
kboyarinov removed 1 blocking reviewer(s) for D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp: Restricted Project.
Nov 16 2021, 7:10 AM · Restricted Project
kboyarinov updated the diff for D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp.

Fixed incorrect upload with arc

Nov 16 2021, 7:10 AM · Restricted Project
kboyarinov removed 1 blocking reviewer(s) for D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp: Restricted Project.
Nov 16 2021, 7:09 AM · Restricted Project
kboyarinov requested review of D113998: [libcxx][NFC] Add tests for associative containers key_comp and value_comp.
Nov 16 2021, 7:04 AM · Restricted Project

Oct 25 2021

kboyarinov requested review of D112438: [libcxx][test][NFC] Various tests for std::vector.
Oct 25 2021, 4:32 AM · Restricted Project
kboyarinov requested review of D112424: [libcxx][test][NFC] More tests for containers comparisons.
Oct 25 2021, 3:18 AM · Restricted Project

Oct 18 2021

kboyarinov updated the diff for D111738: [libcxx][test] Add tests for std::vector comparisons.

Remove negative tests because EqualityComparable is a Precondition for std::vector::operator==. Violation of the precondition results in undefined behavior => the fact that the program is ill-formed is not guaranteed by the standard and should not be tested.

Oct 18 2021, 6:32 AM · Restricted Project

Oct 14 2021

kboyarinov updated the diff for D111738: [libcxx][test] Add tests for std::vector comparisons.

"c++03fication" of the tests

Oct 14 2021, 8:02 AM · Restricted Project
kboyarinov added inline comments to D111738: [libcxx][test] Add tests for std::vector comparisons.
Oct 14 2021, 3:01 AM · Restricted Project

Oct 13 2021

kboyarinov updated the diff for D111738: [libcxx][test] Add tests for std::vector comparisons.

Fix incorrect upload

Oct 13 2021, 9:08 AM · Restricted Project
kboyarinov requested review of D111738: [libcxx][test] Add tests for std::vector comparisons.
Oct 13 2021, 8:59 AM · Restricted Project