This is an archive of the discontinued LLVM Phabricator instance.

[Flang][NFC] Convert static to static inline for a function
ClosedPublic

Authored by kiranchandramohan on Dec 13 2021, 3:19 AM.

Download Raw Diff

Details

Reviewers

clementval
schweitz
mehdi_amini

Commits

rG135d5d4a6d37: [Flang][NFC] Convert static to static inline for a function

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

kiranchandramohan created this revision.Dec 13 2021, 3:19 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 3:19 AM

kiranchandramohan requested review of this revision.Dec 13 2021, 3:19 AM

Herald added a project: Restricted Project. · View Herald TranscriptDec 13 2021, 3:19 AM

Herald added subscribers: llvm-commits, jdoerfert. · View Herald Transcript

kiranchandramohan retitled this revision from [NFC] Convert static to static inline for a function to [Flang][NFC] Convert static to static inline for a function.Dec 13 2021, 3:19 AM

clementval accepted this revision.Dec 13 2021, 3:26 AM

This revision is now accepted and ready to land.Dec 13 2021, 3:26 AM

Harbormaster completed remote builds in B138923: Diff 393830.Dec 13 2021, 3:39 AM

Closed by commit rG135d5d4a6d37: [Flang][NFC] Convert static to static inline for a function (authored by kiranchandramohan). · Explain WhyDec 14 2021, 5:57 AM

This revision was automatically updated to reflect the committed changes.

kiranchandramohan added a commit: rG135d5d4a6d37: [Flang][NFC] Convert static to static inline for a function.

Revision Contents

Path

Size

flang/

lib/

Optimizer/

CodeGen/

CodeGen.cpp

2 lines

Diff 394223

flang/lib/Optimizer/CodeGen/CodeGen.cpp

	Show All 32 Lines
	// TODO: This should really be recovered from the specified target.			// TODO: This should really be recovered from the specified target.
	static constexpr unsigned defaultAlign = 8;			static constexpr unsigned defaultAlign = 8;

	/// `fir.box` attribute values as defined for CFI_attribute_t in			/// `fir.box` attribute values as defined for CFI_attribute_t in
	/// flang/ISO_Fortran_binding.h.			/// flang/ISO_Fortran_binding.h.
	static constexpr unsigned kAttrPointer = CFI_attribute_pointer;			static constexpr unsigned kAttrPointer = CFI_attribute_pointer;
	static constexpr unsigned kAttrAllocatable = CFI_attribute_allocatable;			static constexpr unsigned kAttrAllocatable = CFI_attribute_allocatable;

	static mlir::Type getVoidPtrType(mlir::MLIRContext *context) {			static inline mlir::Type getVoidPtrType(mlir::MLIRContext *context) {
	return mlir::LLVM::LLVMPointerType::get(mlir::IntegerType::get(context, 8));			return mlir::LLVM::LLVMPointerType::get(mlir::IntegerType::get(context, 8));
	}			}

	static mlir::LLVM::ConstantOp			static mlir::LLVM::ConstantOp
	genConstantIndex(mlir::Location loc, mlir::Type ity,			genConstantIndex(mlir::Location loc, mlir::Type ity,
	mlir::ConversionPatternRewriter &rewriter,			mlir::ConversionPatternRewriter &rewriter,
	std::int64_t offset) {			std::int64_t offset) {
	auto cattr = rewriter.getI64IntegerAttr(offset);			auto cattr = rewriter.getI64IntegerAttr(offset);
	▲ Show 20 Lines • Show All 3,091 Lines • Show Last 20 Lines