This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU][NFC] Add documentation for location description DWARF extension
ClosedPublic

Authored by t-tye on Dec 11 2021, 4:02 PM.

Details

Summary

Add documentation for the DWARF extension to allow location descriptions
on the DWARF expression stack. This is part of the "DWARF Extensions For
Heterogeneous Debugging" used by the AMD GPU target.

Diff Detail

Event Timeline

t-tye created this revision.Dec 11 2021, 4:02 PM
t-tye requested review of this revision.Dec 11 2021, 4:02 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 11 2021, 4:02 PM

LGTM, with only typos and minor nits around wording.

I'm OK with you landing this as-is, and addressing these post-commit, if you prefer.

llvm/docs/AMDGPUDwarfExtensionAllowLocationDescriptionOnTheDwarfExpressionStack/AMDGPUDwarfExtensionAllowLocationDescriptionOnTheDwarfExpressionStack.md
34
66
67
111
111

Nit: As the mapping is in both directions, maybe something like "DWARF maps between source program language entities and their hardware representations"?

131
383–384

I have a hard time reading this, I'm still not sure I quite follow it. I assume the intent is to describe how the "base object" feature in DWARF expressions only works if the object is in global memory?

395
427
623
716
743
766

Nit: this is very minor, but extenson should be extension in these filenames

782
795
857
878
900
t-tye updated this revision to Diff 394073.Dec 13 2021, 3:48 PM
t-tye marked 18 inline comments as done.

Update review feedback from @scott.linder .

scott.linder accepted this revision.Dec 13 2021, 4:12 PM
This revision is now accepted and ready to land.Dec 13 2021, 4:12 PM
This revision was landed with ongoing or failed builds.Dec 13 2021, 4:58 PM
This revision was automatically updated to reflect the committed changes.