This is an archive of the discontinued LLVM Phabricator instance.

[mlir] Add filegroup for Conversion/PassDetail
ClosedPublic

Authored by Chia-hungDuan on Dec 9 2021, 5:46 PM.

Diff Detail

Event Timeline

Chia-hungDuan created this revision.Dec 9 2021, 5:46 PM
Chia-hungDuan requested review of this revision.Dec 9 2021, 5:46 PM
mehdi_amini accepted this revision.Dec 9 2021, 5:47 PM
This revision is now accepted and ready to land.Dec 9 2021, 5:47 PM

Could you note in the description what caused us to grow the ROCDL dependency?

Add description

In e1da62910e140cf45eafec64193c813e79796f05, it added
additional dependency to "mlir/Conversion/GPUToROCDL/Runtimes.h" in
"mlir/lib/Conversion/PassDetail.h". It's better to group them together to
reduce the effort for future update.
This revision was landed with ongoing or failed builds.Dec 9 2021, 6:10 PM
This revision was automatically updated to reflect the committed changes.