This is an archive of the discontinued LLVM Phabricator instance.

[ASan] Replace IR based callbacks with shared assembly code callbacks.
ClosedPublic

Authored by kstoimenov on Dec 8 2021, 1:43 PM.

Diff Detail

Unit TestsFailed

Event Timeline

kstoimenov created this revision.Dec 8 2021, 1:43 PM
kstoimenov requested review of this revision.Dec 8 2021, 1:43 PM
Herald added a project: Restricted Project. · View Herald TranscriptDec 8 2021, 1:43 PM
kstoimenov retitled this revision from [ASan] Replace IR optimzied callbacks with shared direct assebly code callbacks. to [ASan] Replace IR based callbacks with shared assembly code callbacks..Dec 8 2021, 1:44 PM
morehouse added inline comments.Dec 9 2021, 9:03 AM
llvm/lib/Target/X86/X86MCInstLower.cpp
1351–1357

We didn't implement OR callbacks, did we? Probably we should not emit calls to them.

kstoimenov updated this revision to Diff 393338.Dec 9 2021, 5:00 PM

Added llvm_unreachable for or.

llvm/lib/Target/X86/X86MCInstLower.cpp
1351–1357

Added llvm_unreachable.

morehouse accepted this revision.Dec 10 2021, 7:32 AM
morehouse added inline comments.
llvm/lib/Target/X86/X86MCInstLower.cpp
1351–1357

Let's move this CHECK to right after the call to getAddressSanitizerParams. And let's hard code Op as "add".

1351–1358
This revision is now accepted and ready to land.Dec 10 2021, 7:32 AM
vitalybuka accepted this revision.Dec 10 2021, 3:07 PM

After pull.

Removed or test.

Added the test for or back.

This revision was landed with ongoing or failed builds.Dec 10 2021, 4:03 PM
This revision was automatically updated to reflect the committed changes.
kstoimenov reopened this revision.Dec 10 2021, 4:43 PM
This revision is now accepted and ready to land.Dec 10 2021, 4:43 PM

Used report_fatal_error.

This revision was landed with ongoing or failed builds.Dec 13 2021, 8:33 AM
This revision was automatically updated to reflect the committed changes.
kstoimenov reopened this revision.Dec 13 2021, 4:35 PM
This revision is now accepted and ready to land.Dec 13 2021, 4:35 PM
kstoimenov closed this revision.Dec 14 2021, 2:10 PM