This is an archive of the discontinued LLVM Phabricator instance.

[ARM][clang] Add back branch protection tests
ClosedPublic

Authored by stuij on Dec 6 2021, 2:57 AM.

Details

Summary

When committing the PACBTI-M frontend support
patch (https://reviews.llvm.org/D112421), the tests in
arm-invalid-branch-protection.c were failing on certain test setups, so it was
removed to make the llvm test suite pass. The fix is to require
arm-registered-target.

This patch is part of a series that adds support for the PACBTI-M extension of
the Armv8.1-M architecture, as detailed here:

https://community.arm.com/arm-community-blogs/b/architectures-and-processors-blog/posts/armv8-1-m-pointer-authentication-and-branch-target-identification-extension

The PACBTI-M specification can be found in the Armv8-M Architecture Reference
Manual:

https://developer.arm.com/documentation/ddi0553/latest

Diff Detail

Event Timeline

stuij created this revision.Dec 6 2021, 2:57 AM
stuij requested review of this revision.Dec 6 2021, 2:57 AM
Herald added a project: Restricted Project. · View Herald TranscriptDec 6 2021, 2:57 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
erichkeane accepted this revision.Dec 6 2021, 6:22 AM

I'm quite sure this is the right fix, the 'requires' clause missing is, I believe, the problems that caused us to revert this test.

This revision is now accepted and ready to land.Dec 6 2021, 6:22 AM
This revision was automatically updated to reflect the committed changes.