This is an archive of the discontinued LLVM Phabricator instance.

Paths

Table of Contentst

-
mlir/test/Integration/Dialect/Linalg/CPU/
-
test/
-
Integration/
-
Dialect/
-
Linalg/
-
CPU/
1
lit.local.cfg

Differential D114857

[mlir][linalg] Disable tensor-matmul test under asan
ClosedPublic

Authored by herhut on Dec 1 2021, 1:57 AM.

Download Raw Diff

Details

Reviewers

nicolasvasilache
mehdi_amini

Commits

rG9fce961d2f47: [mlir][linalg] Disable tensor-matmul test under asan

Summary

The test is currently leaky. Disabling it to make the bots green.

Diff Detail

Repository: rG LLVM Github Monorepo

Event Timeline

herhut created this revision.Dec 1 2021, 1:57 AM

Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptDec 1 2021, 1:57 AM

herhut requested review of this revision.Dec 1 2021, 1:57 AM

Herald added a reviewer: nicolasvasilache. · View Herald TranscriptDec 1 2021, 1:57 AM

Herald added a project: Restricted Project. · View Herald Transcript

Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript

mehdi_amini added inline comments.Dec 1 2021, 2:01 AM

mlir/test/Integration/Dialect/Linalg/CPU/lit.local.cfg
3	I think you should be able to just add inside the test itself: `:// UNSUPPORTED: asan`

Harbormaster completed remote builds in B136875: Diff 390954.Dec 1 2021, 2:13 AM

Use in-test tag as suggested.

Thanks @mehdi_amini ! That is much easier.

mehdi_amini accepted this revision.Dec 1 2021, 4:21 AM

This revision is now accepted and ready to land.Dec 1 2021, 4:21 AM

Can you CC on this revision whoever is following up on this test?

Harbormaster completed remote builds in B136887: Diff 390974.Dec 1 2021, 4:29 AM

I assume that would be @nicolasvasilache as I suspect this is a matmul bufferization issue.

Closed by commit rG9fce961d2f47: [mlir][linalg] Disable tensor-matmul test under asan (authored by herhut). · Explain WhyDec 1 2021, 7:25 AM

This revision was automatically updated to reflect the committed changes.

herhut added a commit: rG9fce961d2f47: [mlir][linalg] Disable tensor-matmul test under asan.

Revision Contents

Path

Size

mlir/

test/

Integration/

Dialect/

Linalg/

CPU/

3 lines

Diff 390954

mlir/test/Integration/Dialect/Linalg/CPU/lit.local.cfg

This file was added.

				# Disabling some leaky tests when running under asan.
				if ('asan' in config.available_features):
				config.excludes.add('test-tensor-matmul.mlir')
				mehdi_aminiUnsubmitted Not Done Reply Inline Actions I think you should be able to just add inside the test itself: `:// UNSUPPORTED: asan` mehdi_amini: I think you should be able to just add inside the test itself: `:// UNSUPPORTED: asan`