This is an archive of the discontinued LLVM Phabricator instance.

Differential D114857

[mlir][linalg] Disable tensor-matmul test under asan
ClosedPublic

Authored by herhut on Dec 1 2021, 1:57 AM.

Details

Reviewers
nicolasvasilache
mehdi_amini
Commits
rG9fce961d2f47: [mlir][linalg] Disable tensor-matmul test under asan
Summary

The test is currently leaky. Disabling it to make the bots green.

Diff Detail

Event Timeline

herhut created this revision.Dec 1 2021, 1:57 AM
Herald added subscribers: sdasgup3, wenzhicui, wrengr and 21 others. · View Herald TranscriptDec 1 2021, 1:57 AM
herhut requested review of this revision.Dec 1 2021, 1:57 AM
Herald added a reviewer: nicolasvasilache. · View Herald TranscriptDec 1 2021, 1:57 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added subscribers: limo1996, stephenneuendorffer, nicolasvasilache. · View Herald Transcript
mehdi_amini added inline comments.Dec 1 2021, 2:01 AM
mlir/test/Integration/Dialect/Linalg/CPU/lit.local.cfg
3 ↗(On Diff #390954)

I think you should be able to just add inside the test itself: :// UNSUPPORTED: asan

Harbormaster completed remote builds in B136875: Diff 390954.Dec 1 2021, 2:13 AM
herhut updated this revision to Diff 390974.Dec 1 2021, 4:14 AM

Use in-test tag as suggested.

herhut added a comment.Dec 1 2021, 4:15 AM

Thanks @mehdi_amini ! That is much easier.

mehdi_amini accepted this revision.Dec 1 2021, 4:21 AM
This revision is now accepted and ready to land.Dec 1 2021, 4:21 AM
mehdi_amini added a comment.Dec 1 2021, 4:22 AM

Can you CC on this revision whoever is following up on this test?

Harbormaster completed remote builds in B136887: Diff 390974.Dec 1 2021, 4:29 AM
herhut added a comment.Dec 1 2021, 7:24 AM

I assume that would be @nicolasvasilache as I suspect this is a matmul bufferization issue.

Closed by commit rG9fce961d2f47: [mlir][linalg] Disable tensor-matmul test under asan (authored by herhut). · Explain WhyDec 1 2021, 7:25 AM
This revision was automatically updated to reflect the committed changes.
herhut added a commit: rG9fce961d2f47: [mlir][linalg] Disable tensor-matmul test under asan.

Revision Contents

PathSize
mlir/
test/
Integration/
Dialect/
Linalg/
CPU/
1 line

Diff 391017

mlir/test/Integration/Dialect/Linalg/CPU/test-tensor-matmul.mlir

// UNSUPPORTED: asan
// RUN: mlir-opt %s -linalg-bufferize -std-bufferize -tensor-constant-bufferize \ // RUN: mlir-opt %s -linalg-bufferize -std-bufferize -tensor-constant-bufferize \
// RUN: -tensor-bufferize -func-bufferize -finalizing-bufferize -buffer-deallocation -convert-linalg-to-loops -convert-scf-to-std \ // RUN: -tensor-bufferize -func-bufferize -finalizing-bufferize -buffer-deallocation -convert-linalg-to-loops -convert-scf-to-std \
// RUN: -convert-linalg-to-llvm -lower-affine -convert-scf-to-std --convert-memref-to-llvm -convert-std-to-llvm -reconcile-unrealized-casts | \ // RUN: -convert-linalg-to-llvm -lower-affine -convert-scf-to-std --convert-memref-to-llvm -convert-std-to-llvm -reconcile-unrealized-casts | \
// RUN: mlir-cpu-runner -e main -entry-point-result=void \ // RUN: mlir-cpu-runner -e main -entry-point-result=void \
// RUN: -shared-libs=%mlir_integration_test_dir/libmlir_runner_utils%shlibext \ // RUN: -shared-libs=%mlir_integration_test_dir/libmlir_runner_utils%shlibext \
// RUN: | FileCheck %s // RUN: | FileCheck %s
// RUN: mlir-opt %s -linalg-tile="tile-sizes=1,2,3" -linalg-bufferize \ // RUN: mlir-opt %s -linalg-tile="tile-sizes=1,2,3" -linalg-bufferize \
Show All 30 Lines