This is an archive of the discontinued LLVM Phabricator instance.

Differential D114707

[AMDGPU] Update docs for nontemporal store
ClosedPublic

Authored by foad on Nov 29 2021, 6:46 AM.

Details

Reviewers
critson
t-tye
Commits
rG5d602120c3a3: [AMDGPU] Update docs for nontemporal store
Summary

Update the documented GFX10 code sequence for nontemporal stores after
D114351.

Diff Detail

Event Timeline

foad created this revision.Nov 29 2021, 6:46 AM
Herald added subscribers: kerbowa, tpr, dstuttard and 4 others. · View Herald TranscriptNov 29 2021, 6:46 AM
foad requested review of this revision.Nov 29 2021, 6:46 AM
Herald added a project: Restricted Project. · View Herald TranscriptNov 29 2021, 6:46 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
foad mentioned this in D114351: [AMDGPU] Add SIMemoryLegalizer comments to clarify bit usage.Nov 29 2021, 6:46 AM
foad updated this revision to Diff 390348.Nov 29 2021, 7:12 AM

Rebase.

Harbormaster completed remote builds in B136444: Diff 390348.Nov 29 2021, 9:25 AM
critson accepted this revision.Nov 30 2021, 1:13 AM

LGTM - thanks for updating this!

This revision is now accepted and ready to land.Nov 30 2021, 1:13 AM
Closed by commit rG5d602120c3a3: [AMDGPU] Update docs for nontemporal store (authored by foad). · Explain WhyNov 30 2021, 1:44 AM
This revision was automatically updated to reflect the committed changes.
foad added a commit: rG5d602120c3a3: [AMDGPU] Update docs for nontemporal store.

Revision Contents

PathSize
llvm/
docs/
2 lines

Diff 390621

llvm/docs/AMDGPUUsage.rst

  • This file is larger than 256 KB, so syntax highlighting is disabled by default.
Show First 20 Lines • Show All 8,671 Lines • ▼ Show 20 Lines .. table:: AMDHSA Memory Model Code Sequences GFX10
load *none* *none* - local 1. ds_load load *none* *none* - local 1. ds_load
store *none* *none* - global - !volatile & !nontemporal store *none* *none* - global - !volatile & !nontemporal
- generic - generic
- private 1. buffer/global/flat_store - private 1. buffer/global/flat_store
- constant - constant
- !volatile & nontemporal - !volatile & nontemporal
1. buffer/global/flat_store 1. buffer/global/flat_store
slc=1 glc=1 slc=1
- volatile - volatile
1. buffer/global/flat_store 1. buffer/global/flat_store
2. s_waitcnt vscnt(0) 2. s_waitcnt vscnt(0)
- Must happen before - Must happen before
any following volatile any following volatile
▲ Show 20 Lines • Show All 3,704 Lines • Show Last 20 Lines