Details
Details
Diff Detail
Diff Detail
- Repository
- rG LLVM Github Monorepo
Event Timeline
mlir/lib/Conversion/VectorToLLVM/ConvertVectorToLLVM.cpp | ||
---|---|---|
60 | rank <= 1 plz | |
1015 | I think the API needs to change here. and then inside the function: VectorType vectorType = type.dyn_cast<VectorType>() ... if (!vectorType) { assert(rank == 0 && "scalar case expects rank == 0"); ... } | |
1056 | The ternary conditions already look too tricky here I find if (rank <= 1) { auto reducedType = vector.getElementType(); auto llvmType = typeConverter->convertType(reducedType); Value nestedVal = extractOne(rewriter, *getTypeConverter(), loc, value, llvmType, rank, d); return emitRanks(rewriter, op, nestedVal, reducedType, printer, /*lowerRank=*/0, } and then you have an opportunity to make the ternaries below simpler. |
rank <= 1 plz