Page MenuHomePhabricator

[clang-format] NFC - recent changes caused clang-format to no longer be clang-formatted.
ClosedPublic

Authored by MyDeveloperDay on Tue, Nov 23, 3:29 AM.

Details

Summary

The following 2 commits caused files in clang-format to no longer be clang-formatted.

we would lose our "clean" status https://releases.llvm.org/13.0.0/tools/clang/docs/ClangFormattedStatus.html

c2271926a4fc - Make clang-format fuzz through Lexing with asserts enabled (https://github.com/llvm/llvm-project/commit/c2271926a4fc )

84bf5e328664 - Fix various problems found by fuzzing. (https://github.com/llvm/llvm-project/commit/84bf5e328664)

Diff Detail

Event Timeline

MyDeveloperDay requested review of this revision.Tue, Nov 23, 3:29 AM
MyDeveloperDay created this revision.
This revision is now accepted and ready to land.Tue, Nov 23, 1:08 PM
owenpan accepted this revision.Tue, Nov 23, 5:37 PM

Thanks for cleaning up after me, and sorry for the mess - do y'all have clang-format set up as a presubmit or do you just remember to format manually?

Thanks for cleaning up after me, and sorry for the mess - do y'all have clang-format set up as a presubmit or do you just remember to format manually?

Its never a problem to clean up after you of all people, happy to do so.

I personally "Format on Save", but my "phabricator patch creation" does a "git clang-format" too.

Thanks for cleaning up after me, and sorry for the mess - do y'all have clang-format set up as a presubmit or do you just remember to format manually?

I think one "problem" is that it did not go through review, otherwise the there were notes in the review. ;)
I use QtCreator with its clang-format integration and the changed lines get formatted as soon as I press ; or }. Additionally I can format the current line(s).

Thanks for cleaning up after me, and sorry for the mess - do y'all have clang-format set up as a presubmit or do you just remember to format manually?

I think one "problem" is that it did not go through review, otherwise the there were notes in the review. ;)

+1