This is an archive of the discontinued LLVM Phabricator instance.

[AMDGPU] Only allow implicit WQM in pixel shaders
ClosedPublic

Authored by critson on Nov 22 2021, 9:23 PM.

Details

Summary

Implicit derivatives are only valid in pixel shaders,
hence only implicitly enable WQM for pixel shaders.
This avoids unintended WQM in other shader types (e.g. compute)
when image sampling instructions are used.

Diff Detail

Event Timeline

critson created this revision.Nov 22 2021, 9:23 PM
critson requested review of this revision.Nov 22 2021, 9:23 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 22 2021, 9:23 PM
This revision is now accepted and ready to land.Nov 23 2021, 10:39 AM
critson updated this revision to Diff 389421.Nov 24 2021, 1:13 AM
  • Add basic tests to confirm WQM is not being inserted in CS/VS/etc
This revision was automatically updated to reflect the committed changes.