This is an archive of the discontinued LLVM Phabricator instance.

Differential D114341

llvm: Allow the cmake 'NONE' release type
Needs ReviewPublic

Authored by • orbea on Nov 21 2021, 3:03 PM.

Details

Reviewers
kazu
Summary

Most cmake projects allow a NONE CMAKE_RELEASE_TYPE which is equivalent to plain in meson. This PR adds to llvm/CMakeLists.txt so the build doesn't error.

Diff Detail

Event Timeline

• orbea created this revision.Nov 21 2021, 3:03 PM
Herald added a subscriber: mgorny. · View Herald TranscriptNov 21 2021, 3:03 PM
• orbea requested review of this revision.Nov 21 2021, 3:03 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 21 2021, 3:03 PM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B135321: Diff 388773.Nov 21 2021, 3:46 PM

Revision Contents

PathSize
llvm/
2 lines

Diff 388773

llvm/CMakeLists.txt

Show First 20 Lines • Show All 271 Lines • ▼ Show 20 Lines
to this source directory as the last argument. to this source directory as the last argument.
This process created the file `CMakeCache.txt' and the directory `CMakeFiles'. This process created the file `CMakeCache.txt' and the directory `CMakeFiles'.
Please delete them.") Please delete them.")
endif() endif()
string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE) string(TOUPPER "${CMAKE_BUILD_TYPE}" uppercase_CMAKE_BUILD_TYPE)
if (CMAKE_BUILD_TYPE AND if (CMAKE_BUILD_TYPE AND
NOT uppercase_CMAKE_BUILD_TYPE MATCHES "^(DEBUG|RELEASE|RELWITHDEBINFO|MINSIZEREL)$") NOT uppercase_CMAKE_BUILD_TYPE MATCHES "^(NONE|DEBUG|RELEASE|RELWITHDEBINFO|MINSIZEREL)$")
message(FATAL_ERROR "Invalid value for CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}") message(FATAL_ERROR "Invalid value for CMAKE_BUILD_TYPE: ${CMAKE_BUILD_TYPE}")
endif() endif()
set(LLVM_LIBDIR_SUFFIX "" CACHE STRING "Define suffix of library directory name (32/64)" ) set(LLVM_LIBDIR_SUFFIX "" CACHE STRING "Define suffix of library directory name (32/64)" )
set(LLVM_TOOLS_INSTALL_DIR "bin" CACHE STRING "Path for binary subdirectory (defaults to 'bin')") set(LLVM_TOOLS_INSTALL_DIR "bin" CACHE STRING "Path for binary subdirectory (defaults to 'bin')")
mark_as_advanced(LLVM_TOOLS_INSTALL_DIR) mark_as_advanced(LLVM_TOOLS_INSTALL_DIR)
▲ Show 20 Lines • Show All 923 Lines • Show Last 20 Lines