Page MenuHomePhabricator

[VP] Canonicalize macros of VPIntrinsics.def
ClosedPublic

Authored by simoll on Thu, Nov 18, 12:28 AM.

Details

Summary

Usage and naming of macros in VPIntrinsics.def has been inconsistent. Rename all property macros to VP_PROPERTY_<name>. Use BEGIN/END scope macros to attach properties to vp intrinsics and SDNodes (instead of specifying either directly with the property macro).
A follow-up patch has documentation on how the macros are (intended) to be used.

Diff Detail

Event Timeline

simoll created this revision.Thu, Nov 18, 12:28 AM
simoll requested review of this revision.Thu, Nov 18, 12:28 AM
Herald added a project: Restricted Project. · View Herald TranscriptThu, Nov 18, 12:28 AM
simoll planned changes to this revision.Thu, Nov 18, 1:14 AM
simoll updated this revision to Diff 388164.Thu, Nov 18, 5:12 AM

Also use the new macros in SelectionDAG.

simoll updated this revision to Diff 388165.Thu, Nov 18, 5:24 AM

NFC. Remove redundant variadic macro parameter.

frasercrmck accepted this revision.Tue, Nov 23, 3:26 AM

LGTM, thanks

This revision is now accepted and ready to land.Tue, Nov 23, 3:26 AM
This revision was automatically updated to reflect the committed changes.