This is an archive of the discontinued LLVM Phabricator instance.

Remove a useless temporary of a base class type.
ClosedPublic

Authored by alexfh on Nov 17 2021, 10:57 AM.

Details

Summary

This was found by clang-tidy bugprone-undelegated-constructor check.
Was there since the very first commit back in 2016.

Diff Detail

Event Timeline

alexfh requested review of this revision.Nov 17 2021, 10:57 AM
alexfh created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptNov 17 2021, 10:57 AM

@labath Do you know what the status is of removing RenderScript altogether?

labath accepted this revision.Nov 17 2021, 10:41 PM
labath added subscribers: danalbert, srhines.

@labath Do you know what the status is of removing RenderScript altogether?

Not really, but let me tag some people who might (@danalbert, @srhines).

In either case, this change is obviously correct.

This revision is now accepted and ready to land.Nov 17 2021, 10:41 PM
clayborg accepted this revision.Nov 18 2021, 11:49 AM
srhines accepted this revision.Nov 18 2021, 12:00 PM

Per https://developer.android.com/guide/topics/renderscript/migrate, we are starting to turn things down as part of the deprecation. I reached out internally to the folks helping with that to make sure that we don't cause problems by deleting upstream code. I suspect that we'll be able to make more progress with adapting upstream soon. In the meantime, this CL is fine.

alexfh updated this revision to Diff 479873.Dec 3 2022, 3:00 PM

Rebased.

Herald added a project: Restricted Project. · View Herald TranscriptDec 3 2022, 3:00 PM
Herald added a subscriber: Michael137. · View Herald Transcript
This revision was landed with ongoing or failed builds.Dec 3 2022, 3:01 PM
This revision was automatically updated to reflect the committed changes.