This is an archive of the discontinued LLVM Phabricator instance.


Authored by ldionne on Nov 15 2021, 1:48 PM.



All supported compilers support spaceship in C++20 nowadays.

Diff Detail

Event Timeline

ldionne created this revision.Nov 15 2021, 1:48 PM
ldionne requested review of this revision.Nov 15 2021, 1:48 PM
Herald added a project: Restricted Project. · View Herald TranscriptNov 15 2021, 1:48 PM
Herald added a reviewer: Restricted Project. · View Herald Transcript
jloser added a subscriber: jloser.Nov 15 2021, 2:03 PM

I'm happy if CI is green.

I'm happy if CI is green.

Thanks! I am expecting it to be green, but wanted to make sure so I created this :)

Quuxplusone added a subscriber: Quuxplusone.

I do wonder if CI is really going to be green. After all, it's not just that the lexer must support <=>, but we rely on the conforming behavior of =default, and synthesized candidates, and so on. But if you're really sure that all supported compilers do all that stuff, then sure, go for it.


Ping on D110738, btw. ;)

ldionne updated this revision to Diff 387601.Nov 16 2021, 6:18 AM

Rebase onto main (after the coroutines change)

ldionne accepted this revision as: Restricted Project.Nov 16 2021, 6:23 AM

Will ship when/if CI is green.

This revision is now accepted and ready to land.Nov 16 2021, 6:23 AM
Mordante accepted this revision.Nov 16 2021, 7:20 AM
Mordante added a subscriber: Mordante.

Nice cleanup LGTM after CI passes.

This revision was automatically updated to reflect the committed changes.