Page MenuHomePhabricator

[llvm-reduce] Assert that the number of chunks does not change with reductions
AcceptedPublic

Authored by aeubanks on Fri, Nov 12, 4:08 PM.

Details

Reviewers
reames
Meinersbur
Summary

Followup to D113537.

Diff Detail

Unit TestsFailed

TimeTest
220 msx64 debian > LLVM.tools/llvm-reduce::remove-metadata-args.ll
Script: -- : 'RUN: at line 1'; llvm-reduce /var/lib/buildkite-agent/builds/llvm-project/llvm/test/tools/llvm-reduce/remove-metadata-args.ll -o /var/lib/buildkite-agent/builds/llvm-project/build/test/tools/llvm-reduce/Output/remove-metadata-args.ll.tmp --delta-passes=metadata --test /var/lib/buildkite-agent/builds/llvm-project/build/bin/FileCheck --test-arg /var/lib/buildkite-agent/builds/llvm-project/llvm/test/tools/llvm-reduce/remove-metadata-args.ll --test-arg --check-prefix=EXCITING --test-arg --input-file

Event Timeline

aeubanks requested review of this revision.Fri, Nov 12, 4:08 PM
aeubanks created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 12, 4:08 PM
aeubanks updated this revision to Diff 386977.Fri, Nov 12, 4:10 PM

remove logging

Approach looks good to me.

remove-metadata-args.ll / --delta-passes=metadata is failing, which I might have been responsible for. Do you want me to have a look?

Approach looks good to me.

remove-metadata-args.ll / --delta-passes=metadata is failing, which I might have been responsible for. Do you want me to have a look?

I have https://reviews.llvm.org/D113812 and https://reviews.llvm.org/D113808 out for that.

Meinersbur accepted this revision.Mon, Nov 15, 11:23 AM

Thanks. Assuming those go in, this patch LGTM.

This revision is now accepted and ready to land.Mon, Nov 15, 11:23 AM