Page MenuHomePhabricator

[Cloning] Clone metadata on function declarations
Needs ReviewPublic

Authored by aeubanks on Fri, Nov 12, 3:49 PM.

Details

Reviewers
dexonsmith
Summary

Previously we missed cloning metadata on function declarations because
we don't call CloneFunctionInto() on declarations in CloneModule().

Diff Detail

Event Timeline

aeubanks created this revision.Fri, Nov 12, 3:49 PM
aeubanks requested review of this revision.Fri, Nov 12, 3:49 PM
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 12, 3:49 PM

Huh... when did metadata get added to function declarations? I'm not sure what the semantics of those are supposed to be. I seem to remember that been left out when metadata was added for definitions.

Huh... when did metadata get added to function declarations?

Since D21052