Page MenuHomePhabricator

[ASTImporter][NFC] Dump decl name at assertion violation

Authored by steakhal on Thu, Nov 11, 5:46 AM.



Sometimes it would be useful to see which Decl kind caused some issue,
along with the name of the concrete instance of the Decl in the source

Diff Detail

Event Timeline

steakhal created this revision.Thu, Nov 11, 5:46 AM
steakhal requested review of this revision.Thu, Nov 11, 5:46 AM
shafik added inline comments.Thu, Nov 11, 8:22 AM

This feels more like an assert case rather than an llvm_unreachable case.

steakhal marked an inline comment as done.Thu, Nov 11, 9:10 AM
steakhal added inline comments.

I want to display a runtime constructed error message before actually terminating the application. AFAIK asserts cannot accomplish this.

martong accepted this revision.Fri, Nov 12, 5:08 AM


This revision is now accepted and ready to land.Fri, Nov 12, 5:08 AM
This revision was automatically updated to reflect the committed changes.
Herald added a project: Restricted Project. · View Herald TranscriptFri, Nov 19, 2:31 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript