Page MenuHomePhabricator

[clangd] Mark macros from preamble for code completion
ClosedPublic

Authored by kadircet on Wed, Nov 10, 3:12 AM.

Details

Summary

If the main file is a header, mark the marcos defined in its preamble
section as code-completion ready.

Fixes https://github.com/clangd/clangd/issues/921.

Diff Detail

Event Timeline

kadircet created this revision.Wed, Nov 10, 3:12 AM
kadircet requested review of this revision.Wed, Nov 10, 3:12 AM
usaxena95 accepted this revision.Wed, Nov 10, 9:38 AM
usaxena95 added inline comments.
clang-tools-extra/clangd/index/SymbolCollector.cpp
567

Please add a comment about this (maybe similar to the parch description)

This revision is now accepted and ready to land.Wed, Nov 10, 9:38 AM
This revision was automatically updated to reflect the committed changes.
kadircet marked an inline comment as done.