[mlir][sparse] Rename SparseUtils.cpp file to SparseTensorUtils.cpp

[HarrietAkot]

Summary

Bug 52304 - Rename the sparse runtime support library cpp file

[aartbik]

Much better! I updated the summary, because it is a bit strange to include a link to a file you are renaming (making it stale after this revision).
Also I think you also need to update:

clang/docs/tools/clang-formatted-files.txt

where there is one more occurrence of the "old" SparseUtils.cpp

mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

1

While you are here, how about changing the contents to

//===- SparseTensorUtils.cpp - Sparse tensor utils for MLIR execution

to make it more consistent with the name

[HarrietAkot]

"[mlir][sparse]Editing Patch-Rename SparseUtils.cpp library"

[HarrietAkot]

• "Edit the contents of SparseTensorUtils.cpp"

[aartbik]

Did you see my comment on clang/docs/tools/clang-formatted-files.txt?
You will need to update that file too (SparseUtils.cpp -> SparseTensorUtils.cpp)

after that this revision is good to go!
(do you have submit rights, or do you want me to do that, once we are there?)

[HarrietAkot]

• "Updating clang-formatted-files"

[aartbik]

One last question, I just noticed you started a whole new revision (instead of updating https://reviews.llvm.org/D112995).

Was that intentional?

If you use arc, then arc diff .... first time creates one, but subsequent updates should use arc diff ... --update Dxxxx to make sure we stay in one revision.
It is not a big deal, we can proceed with this one and abandon the other, but just making sure you are aware of the procedure.

[HarrietAkot]

In D113043#3103979, @aartbik wrote:

Did you see my comment on clang/docs/tools/clang-formatted-files.txt?
You will need to update that file too (SparseUtils.cpp -> SparseTensorUtils.cpp)

after that this revision is good to go!
(do you have submit rights, or do you want me to do that, once we are there?)

I have made the changes to the clang-formatted-files.txt. Kindly submit this revision for me. Thank you

mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

1

Done :)

[aartbik]

I removed the quotes from the title, no need for these. Also, please address the last open question (on arc diff --update).

But good to go as revision.

I have approved the revision and will submit this one for you. Congrats on your first contribution to sparse compilation!

mlir/lib/ExecutionEngine/CMakeLists.txt

 # Exclude these from libMLIR.so because the JIT infrastructure
 # is a big dependency which most don't need.
 
 set(LLVM_OPTIONAL_SOURCES
   AsyncRuntime.cpp
   CRunnerUtils.cpp
   CudaRuntimeWrappers.cpp
-  SparseUtils.cpp
+  SparseTensorUtils.cpp
   ExecutionEngine.cpp
   RocmRuntimeWrappers.cpp
   RunnerUtils.cpp
   OptUtils.cpp
   JitRunner.cpp
   )
 
 add_mlir_library(MLIRExecutionEngine
add_mlir_library(MLIRJitRunner
   MLIRTransforms
   MLIRStandardToLLVM
   MLIRSupport
 )
 
 add_mlir_library(mlir_c_runner_utils
   SHARED
   CRunnerUtils.cpp
-  SparseUtils.cpp
+  SparseTensorUtils.cpp
 
   EXCLUDE_FROM_LIBMLIR
   )
 set_property(TARGET mlir_c_runner_utils PROPERTY CXX_STANDARD 11)
 target_compile_definitions(mlir_c_runner_utils PRIVATE mlir_c_runner_utils_EXPORTS)
 
 add_mlir_library(mlir_runner_utils
   SHARED

mlir/lib/ExecutionEngine/SparseTensorUtils.cpp

-//===- SparseUtils.cpp - Sparse Utils for MLIR execution ------------------===//
+//===- SparseTensorUtils.cpp - Sparse Tensor Utils for MLIR execution -----===//
 //
 // Part of the LLVM Project, under the Apache License v2.0 with LLVM Exceptions.
 // See https://llvm.org/LICENSE.txt for license information.
 // SPDX-License-Identifier: Apache-2.0 WITH LLVM-exception
 //
 //===----------------------------------------------------------------------===//
 //
 // This file implements a light-weight runtime support library that is useful