This is an archive of the discontinued LLVM Phabricator instance.

[docs] Expand a bit on the basics of a buildbot policy
ClosedPublic

Authored by reames on Oct 28 2021, 1:53 PM.

Details

Summary

We don't have much publicly documented about how build bots are maintained, and who has what responsibility with regards to the bots themselves and failures they report.

This change adds some basic framing on the topic. It is intended to simplify document long standing practice, and to avoid introducing any new policy elements. I do want to propose a couple of changes, but those will happen with their own review and broader discussion.

Diff Detail

Event Timeline

reames created this revision.Oct 28 2021, 1:53 PM
reames requested review of this revision.Oct 28 2021, 1:53 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 28 2021, 1:53 PM
gkistanova accepted this revision.Oct 28 2021, 2:28 PM

Thanks, Philip!

LGTM.

This revision is now accepted and ready to land.Oct 28 2021, 2:28 PM
This revision was landed with ongoing or failed builds.Oct 28 2021, 2:51 PM
This revision was automatically updated to reflect the committed changes.

LG! Thanks

llvm/docs/HowToAddABuilder.rst
50

We should document how to find this information. Some colleagues somehow couldn't find it in the web interface so it may no be obvious to everyone.

Sounds good - thanks for writing that up!

reames added inline comments.Oct 28 2021, 5:43 PM
llvm/docs/HowToAddABuilder.rst
50

That snippet really seems like it should be out of line with the developer docs. Would moving the content below "If a build/worker is permanently broken" into this page, and linking from that one seem reasonable?

(I'll do it in a separate review for sanity check, just checking big picture feasibility.)

LG! Thanks

llvm/docs/HowToAddABuilder.rst
50

Nice snippet Galina! This is exactly what I had in mind.

Moving it here and linking from the dev doc to here seems fine to me as well.

reames added inline comments.Oct 28 2021, 6:25 PM
llvm/docs/HowToAddABuilder.rst
50