This is an archive of the discontinued LLVM Phabricator instance.

[mlir][sparse] move conversion test back to original CHECK testing
ClosedPublic

Authored by aartbik on Oct 27 2021, 8:36 PM.

Details

Summary

Rationale:
The silent exit(1) gives little clues on where the error occurs on failure
and may even be confusing at first. The CHECK testing of all computed values
and indices may be a little bit more elaborate, but it directly pinpoints
where errors happen if they occur. This style is also consistent with
the other tests, which I actually prefer.

Diff Detail

Event Timeline

aartbik created this revision.Oct 27 2021, 8:36 PM
aartbik requested review of this revision.Oct 27 2021, 8:36 PM
aartbik edited the summary of this revision. (Show Details)Oct 27 2021, 8:37 PM
aartbik updated this revision to Diff 382900.Oct 27 2021, 8:39 PM

fixed empty line

bixia accepted this revision.Oct 28 2021, 8:08 AM
This revision is now accepted and ready to land.Oct 28 2021, 8:08 AM