This is an archive of the discontinued LLVM Phabricator instance.

Differential D112627

[clang] Inclusive language: change error message to use allowlist
ClosedPublic

Authored by ZarkoCA on Oct 27 2021, 8:33 AM.

Details

Reviewers
tuktuk
vitalybuka
MaskRay
quinnp
Commits
rGc001775a3afb: [clang] Inclusive language: change error message to use allowlist

Diff Detail

Unit TestsFailed

TimeTest
1,370 msx64 debian > SanitizerCommon-asan-x86_64-Linux.SanitizerCommon-asan-x86_64-Linux::onprint.cpp
340 msx64 debian > SanitizerCommon-lsan-x86_64-Linux.SanitizerCommon-lsan-x86_64-Linux::onprint.cpp
550 msx64 debian > SanitizerCommon-msan-x86_64-Linux.SanitizerCommon-msan-x86_64-Linux::onprint.cpp
1,590 msx64 debian > SanitizerCommon-tsan-x86_64-Linux.SanitizerCommon-tsan-x86_64-Linux::onprint.cpp
520 msx64 debian > SanitizerCommon-ubsan-x86_64-Linux.SanitizerCommon-ubsan-x86_64-Linux::onprint.cpp

Event Timeline

ZarkoCA requested review of this revision.Oct 27 2021, 8:33 AM
ZarkoCA created this revision.
Herald added a subscriber: cfe-commits. · View Herald TranscriptOct 27 2021, 8:33 AM
ZarkoCA added a reviewer: quinnp.Oct 27 2021, 8:33 AM
Harbormaster completed remote builds in B130963: Diff 382682.Oct 27 2021, 9:19 AM
vitalybuka accepted this revision.Oct 27 2021, 12:55 PM
This revision is now accepted and ready to land.Oct 27 2021, 12:55 PM
This revision was landed with ongoing or failed builds.Oct 29 2021, 10:12 AM
Closed by commit rGc001775a3afb: [clang] Inclusive language: change error message to use allowlist (authored by ZarkoCA). · Explain Why
This revision was automatically updated to reflect the committed changes.
ZarkoCA added a commit: rGc001775a3afb: [clang] Inclusive language: change error message to use allowlist.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
4 lines
lib/
Driver/
2 lines

Diff 382682

clang/include/clang/Basic/DiagnosticDriverKinds.td

Show First 20 Lines • Show All 181 Lines • ▼ Show 20 Lines
def err_drv_missing_arg_mtp : Error< def err_drv_missing_arg_mtp : Error<
"missing argument to '%0'">; "missing argument to '%0'">;
def err_drv_invalid_libcxx_deployment : Error< def err_drv_invalid_libcxx_deployment : Error<
"invalid deployment target for -stdlib=libc++ (requires %0 or later)">; "invalid deployment target for -stdlib=libc++ (requires %0 or later)">;
def err_drv_invalid_argument_to_option : Error< def err_drv_invalid_argument_to_option : Error<
"invalid argument '%0' to -%1">; "invalid argument '%0' to -%1">;
def err_drv_malformed_sanitizer_ignorelist : Error< def err_drv_malformed_sanitizer_ignorelist : Error<
"malformed sanitizer ignorelist: '%0'">; "malformed sanitizer ignorelist: '%0'">;
def err_drv_malformed_sanitizer_coverage_whitelist : Error< def err_drv_malformed_sanitizer_coverage_allowlist : Error<
"malformed sanitizer coverage whitelist: '%0'">; "malformed sanitizer coverage allowlist: '%0'">;
def err_drv_malformed_sanitizer_coverage_ignorelist : Error< def err_drv_malformed_sanitizer_coverage_ignorelist : Error<
"malformed sanitizer coverage ignorelist: '%0'">; "malformed sanitizer coverage ignorelist: '%0'">;
def err_drv_duplicate_config : Error< def err_drv_duplicate_config : Error<
"no more than one option '--config' is allowed">; "no more than one option '--config' is allowed">;
def err_drv_config_file_not_exist : Error< def err_drv_config_file_not_exist : Error<
"configuration file '%0' does not exist">; "configuration file '%0' does not exist">;
def err_drv_config_file_not_found : Error< def err_drv_config_file_not_found : Error<
"configuration file '%0' cannot be found">; "configuration file '%0' cannot be found">;
▲ Show 20 Lines • Show All 396 Lines • Show Last 20 Lines

clang/lib/Driver/SanitizerArgs.cpp

Show First 20 Lines • Show All 749 Lines • ▼ Show 20 LinesSanitizerArgs::SanitizerArgs(const ToolChain &TC,
// Parse -fsanitize-coverage-(ignore|white)list options if coverage enabled. // Parse -fsanitize-coverage-(ignore|white)list options if coverage enabled.
// This also validates special case lists format. // This also validates special case lists format.
// Here, OptSpecifier() acts as a never-matching command-line argument. // Here, OptSpecifier() acts as a never-matching command-line argument.
// So, there is no way to clear coverage lists but you can append to them. // So, there is no way to clear coverage lists but you can append to them.
if (CoverageFeatures) { if (CoverageFeatures) {
parseSpecialCaseListArg( parseSpecialCaseListArg(
D, Args, CoverageAllowlistFiles, D, Args, CoverageAllowlistFiles,
options::OPT_fsanitize_coverage_allowlist, OptSpecifier(), options::OPT_fsanitize_coverage_allowlist, OptSpecifier(),
clang::diag::err_drv_malformed_sanitizer_coverage_whitelist); clang::diag::err_drv_malformed_sanitizer_coverage_allowlist);
parseSpecialCaseListArg( parseSpecialCaseListArg(
D, Args, CoverageIgnorelistFiles, D, Args, CoverageIgnorelistFiles,
options::OPT_fsanitize_coverage_ignorelist, OptSpecifier(), options::OPT_fsanitize_coverage_ignorelist, OptSpecifier(),
clang::diag::err_drv_malformed_sanitizer_coverage_ignorelist); clang::diag::err_drv_malformed_sanitizer_coverage_ignorelist);
} }
SharedRuntime = SharedRuntime =
Args.hasFlag(options::OPT_shared_libsan, options::OPT_static_libsan, Args.hasFlag(options::OPT_shared_libsan, options::OPT_static_libsan,
▲ Show 20 Lines • Show All 526 Lines • Show Last 20 Lines