Page MenuHomePhabricator

tuktuk (Yannis Juglaret)
User

Projects

User does not belong to any projects.

User Details

User Since
Mar 29 2019, 12:30 PM (25 w, 2 d)

Recent Activity

Jun 28 2019

tuktuk added a comment to D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

Thanks for the reviews.

Jun 28 2019, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
tuktuk updated the summary of D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.
Jun 28 2019, 12:28 PM · Restricted Project, Restricted Project, Restricted Project
tuktuk updated the diff for D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

I followed Matt Morehouse's advice: mainly, I adapted the test so that it uses libFuzzer's default SanitizerCoverage options instead of trace-pc, and I rewrote some parts of the code to make it less redundant.

Jun 28 2019, 10:09 AM · Restricted Project, Restricted Project, Restricted Project

Jun 21 2019

tuktuk updated the diff for D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.

I followed Roman Lebedev's advice and adapted the sanitizer_coverage_no_prune.cc test to create a sanitizer_coverage_whitelist_blacklist.cc test under make check_sanitizer. I can only try the test on a Linux machine, and it passes on that machine.

Jun 21 2019, 8:28 AM · Restricted Project, Restricted Project, Restricted Project

Jun 20 2019

tuktuk created D63616: Implement `-fsanitize-coverage-whitelist` and `-fsanitize-coverage-blacklist` for clang.
Jun 20 2019, 11:36 AM · Restricted Project, Restricted Project, Restricted Project

Apr 5 2019

tuktuk added a comment to D60008: Use binary write mode in WriteToFile function to avoid appended \r characters on Windows.

It's good as it is, you can submit the patch. Thanks for your time!

Apr 5 2019, 1:13 PM · Restricted Project, Restricted Project

Apr 1 2019

tuktuk added a comment to D60008: Use binary write mode in WriteToFile function to avoid appended \r characters on Windows.

Looks good to me! Here are the results without / with patch.

Apr 1 2019, 1:53 PM · Restricted Project, Restricted Project

Mar 30 2019

tuktuk added a comment to D60008: Use binary write mode in WriteToFile function to avoid appended \r characters on Windows.

There is a problem with that generic solution which is that nothing in it forces libfuzzer to generate multiple byte values and in my experiments the data I get is always very poorly distributed, so in practice it is not that generic.
I tried a fuzz target that would force libfuzzer to have at least one instance of every possible byte value, but libfuzzer wouldn't manage to generate appropriate data.
However I can confirm that the following fuzz target can be used to differentiate between pre-patch and patched versions following the (non-)reproducibility test we talked about:

Mar 30 2019, 11:21 AM · Restricted Project, Restricted Project

Mar 29 2019

tuktuk added a comment to D60008: Use binary write mode in WriteToFile function to avoid appended \r characters on Windows.

Oh, can you add a test so it fail without the patch on Windows?

Mar 29 2019, 4:20 PM · Restricted Project, Restricted Project
tuktuk created D60008: Use binary write mode in WriteToFile function to avoid appended \r characters on Windows.
Mar 29 2019, 12:40 PM · Restricted Project, Restricted Project