This is an archive of the discontinued LLVM Phabricator instance.

Differential D112521

[CUDA][NFC] Fix inexact warning message about lambdas
ClosedPublic

Authored by benshi001 on Oct 26 2021, 1:50 AM.

Details

Reviewers
tra
fodinabor
Hahnfeld
yaxunl
MaskRay
Commits
rG9c7ace60aa62: [CUDA][NFC] Fix inexact warning message about lambdas

Diff Detail

Event Timeline

benshi001 requested review of this revision.Oct 26 2021, 1:50 AM
benshi001 created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 26 2021, 1:50 AM
Herald added a subscriber: cfe-commits. · View Herald Transcript
benshi001 added a comment.Oct 26 2021, 1:51 AM

Acutally lambdas with CUDA attributes can have non-empty parameter list, and the original warning message is inexact.

Harbormaster completed remote builds in B130631: Diff 382224.Oct 26 2021, 2:16 AM
benshi001 added a reviewer: MaskRay.Oct 26 2021, 2:37 AM
tra accepted this revision.Oct 26 2021, 11:17 AM
This revision is now accepted and ready to land.Oct 26 2021, 11:17 AM
Closed by commit rG9c7ace60aa62: [CUDA][NFC] Fix inexact warning message about lambdas (authored by benshi001). · Explain WhyOct 26 2021, 6:29 PM
This revision was automatically updated to reflect the committed changes.
benshi001 added a commit: rG9c7ace60aa62: [CUDA][NFC] Fix inexact warning message about lambdas.

Revision Contents

PathSize
clang/
include/
clang/
Basic/
2 lines
test/
Parser/
18 lines

Diff 382224

clang/include/clang/Basic/DiagnosticParseKinds.td

Show First 20 Lines • Show All 1,489 Lines • ▼ Show 20 Linesdef err_pragma_pipeline_invalid_keyword : Error<
"invalid argument; expected 'disable'">; "invalid argument; expected 'disable'">;
// Pragma unroll support. // Pragma unroll support.
def warn_pragma_unroll_cuda_value_in_parens : Warning< def warn_pragma_unroll_cuda_value_in_parens : Warning<
"argument to '#pragma unroll' should not be in parentheses in CUDA C/C++">, "argument to '#pragma unroll' should not be in parentheses in CUDA C/C++">,
InGroup<CudaCompat>; InGroup<CudaCompat>;
def warn_cuda_attr_lambda_position : Warning< def warn_cuda_attr_lambda_position : Warning<
"nvcc does not allow '__%0__' to appear after '()' in lambdas">, "nvcc does not allow '__%0__' to appear after the parameter list in lambdas">,
InGroup<CudaCompat>; InGroup<CudaCompat>;
def warn_pragma_force_cuda_host_device_bad_arg : Warning< def warn_pragma_force_cuda_host_device_bad_arg : Warning<
"incorrect use of #pragma clang force_cuda_host_device begin|end">, "incorrect use of #pragma clang force_cuda_host_device begin|end">,
InGroup<IgnoredPragmas>; InGroup<IgnoredPragmas>;
def err_pragma_cannot_end_force_cuda_host_device : Error< def err_pragma_cannot_end_force_cuda_host_device : Error<
"force_cuda_host_device end pragma without matching " "force_cuda_host_device end pragma without matching "
"force_cuda_host_device begin">; "force_cuda_host_device begin">;
} // end of Parse Issue category. } // end of Parse Issue category.
▲ Show 20 Lines • Show All 67 Lines • Show Last 20 Lines

clang/test/Parser/lambda-attr.cu

// RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s // RUN: %clang_cc1 -std=c++11 -fsyntax-only -verify %s
// RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcuda-is-device -verify %s // RUN: %clang_cc1 -std=c++11 -fsyntax-only -fcuda-is-device -verify %s
__attribute__((device)) void device_fn() {} __attribute__((device)) void device_fn() {}
__attribute__((host, device)) void hd_fn() {} __attribute__((host, device)) void hd_fn() {}
__attribute__((device)) void device_attr() { __attribute__((device)) void device_attr() {
([]() __attribute__((device)) { device_fn(); })(); ([]() __attribute__((device)) { device_fn(); })();
// expected-warning@-1 {{nvcc does not allow '__device__' to appear after '()' in lambdas}} // expected-warning@-1 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}}
([] __attribute__((device)) () { device_fn(); })(); ([] __attribute__((device)) () { device_fn(); })();
([] __attribute__((device)) { device_fn(); })(); ([] __attribute__((device)) { device_fn(); })();
([&]() __attribute__((device)){ device_fn(); })(); ([&]() __attribute__((device)){ device_fn(); })();
// expected-warning@-1 {{nvcc does not allow '__device__' to appear after '()' in lambdas}} // expected-warning@-1 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}}
([&] __attribute__((device)) () { device_fn(); })(); ([&] __attribute__((device)) () { device_fn(); })();
([&] __attribute__((device)) { device_fn(); })(); ([&] __attribute__((device)) { device_fn(); })();
([&](int) __attribute__((device)){ device_fn(); })(0); ([&](int) __attribute__((device)){ device_fn(); })(0);
// expected-warning@-1 {{nvcc does not allow '__device__' to appear after '()' in lambdas}} // expected-warning@-1 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}}
([&] __attribute__((device)) (int) { device_fn(); })(0); ([&] __attribute__((device)) (int) { device_fn(); })(0);
} }
__attribute__((host)) __attribute__((device)) void host_device_attrs() { __attribute__((host)) __attribute__((device)) void host_device_attrs() {
([]() __attribute__((host)) __attribute__((device)){ hd_fn(); })(); ([]() __attribute__((host)) __attribute__((device)){ hd_fn(); })();
// expected-warning@-1 {{nvcc does not allow '__host__' to appear after '()' in lambdas}} // expected-warning@-1 {{nvcc does not allow '__host__' to appear after the parameter list in lambdas}}
// expected-warning@-2 {{nvcc does not allow '__device__' to appear after '()' in lambdas}} // expected-warning@-2 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}}
([] __attribute__((host)) __attribute__((device)) () { hd_fn(); })(); ([] __attribute__((host)) __attribute__((device)) () { hd_fn(); })();
([] __attribute__((host)) __attribute__((device)) { hd_fn(); })(); ([] __attribute__((host)) __attribute__((device)) { hd_fn(); })();
([&]() __attribute__((host)) __attribute__((device)){ hd_fn(); })(); ([&]() __attribute__((host)) __attribute__((device)){ hd_fn(); })();
// expected-warning@-1 {{nvcc does not allow '__host__' to appear after '()' in lambdas}} // expected-warning@-1 {{nvcc does not allow '__host__' to appear after the parameter list in lambdas}}
// expected-warning@-2 {{nvcc does not allow '__device__' to appear after '()' in lambdas}} // expected-warning@-2 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}}
([&] __attribute__((host)) __attribute__((device)) () { hd_fn(); })(); ([&] __attribute__((host)) __attribute__((device)) () { hd_fn(); })();
([&] __attribute__((host)) __attribute__((device)) { hd_fn(); })(); ([&] __attribute__((host)) __attribute__((device)) { hd_fn(); })();
([&](int) __attribute__((host)) __attribute__((device)){ hd_fn(); })(0); ([&](int) __attribute__((host)) __attribute__((device)){ hd_fn(); })(0);
// expected-warning@-1 {{nvcc does not allow '__host__' to appear after '()' in lambdas}} // expected-warning@-1 {{nvcc does not allow '__host__' to appear after the parameter list in lambdas}}
// expected-warning@-2 {{nvcc does not allow '__device__' to appear after '()' in lambdas}} // expected-warning@-2 {{nvcc does not allow '__device__' to appear after the parameter list in lambdas}}
([&] __attribute__((host)) __attribute__((device)) (int) { hd_fn(); })(0); ([&] __attribute__((host)) __attribute__((device)) (int) { hd_fn(); })(0);
} }
// TODO: Add tests for __attribute__((global)) once we support global lambdas. // TODO: Add tests for __attribute__((global)) once we support global lambdas.