This is an archive of the discontinued LLVM Phabricator instance.

[libcxx][test][NFC] More tests for containers comparisons
ClosedPublic

Authored by kboyarinov on Oct 25 2021, 3:18 AM.

Details

Summary

Add more missing tests for comparisons to improve code coverage (follow-up for D111738).

Diff Detail

Event Timeline

kboyarinov requested review of this revision.Oct 25 2021, 3:18 AM
kboyarinov created this revision.
ldionne accepted this revision.Oct 28 2021, 8:39 AM

LGTM.

As a small note, please try to follow https://llvm.org/docs/Phabricator.html#requesting-a-review-via-the-command-line next time when uploading a patch, since that will make sure context is added to the diff (right now Phabricator says "Context not available"). Let's land this, thanks again for adding coverage!

This revision is now accepted and ready to land.Oct 28 2021, 8:39 AM
rarutyun accepted this revision.Nov 3 2021, 5:44 AM

Thanks @kboyarinov. LGTM.

This revision was automatically updated to reflect the committed changes.