This is an archive of the discontinued LLVM Phabricator instance.

A hot fix for a reduction parallel pattern of OpenMP backend
ClosedPublic

Authored by MikeDvorskiy on Oct 20 2021, 12:58 AM.

Details

Summary

A hot fix for OpenMP backend; + "exit" condition for recursion of "__parallel_reduce_body"

Diff Detail

Event Timeline

MikeDvorskiy created this revision.Oct 20 2021, 12:58 AM
MikeDvorskiy requested review of this revision.Oct 20 2021, 12:58 AM
Herald added a project: Restricted Project. · View Herald Transcript
Herald added a reviewer: Restricted Project. · View Herald Transcript

clang format

MikeDvorskiy updated this revision to Diff 380901.EditedOct 20 2021, 4:53 AM

A hot performance fix for parallel reduce pattern of OpenMP backend. The recursion should be limited by a grain size - __default_chunk_size.

nadiasvertex accepted this revision.Oct 20 2021, 11:34 AM
nadiasvertex added a subscriber: nadiasvertex.

Thank you! I fixed that bug once, but in the various changes I missed it the last time.

ldionne accepted this revision.Oct 27 2021, 7:16 AM
This revision is now accepted and ready to land.Oct 27 2021, 7:16 AM