This is an archive of the discontinued LLVM Phabricator instance.

Differential D112091

libfuzzer: All building libfuzzer for ARM32
ClosedPublic

Authored by manojgupta on Oct 19 2021, 12:57 PM.

Details

Reviewers
metzman
kcc
morehouse
Commits
rG2782cb8da0b3: libfuzzer: All building libfuzzer for ARM32
Summary

We need libfuzzer libraries on Arm32 so that we can fuzz
Arm32 binaries on Linux (Chrome OS). Android already
allows Arm32 for libfuzzer.

Diff Detail

Event Timeline

manojgupta created this revision.Oct 19 2021, 12:57 PM
Herald added subscribers: kristof.beyls, mgorny. · View Herald TranscriptOct 19 2021, 12:57 PM
manojgupta requested review of this revision.Oct 19 2021, 12:57 PM
Herald added a project: Restricted Project. · View Herald TranscriptOct 19 2021, 12:57 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
manojgupta added a reviewer: kcc.Oct 19 2021, 1:09 PM
Harbormaster completed remote builds in B129597: Diff 380761.Oct 19 2021, 1:14 PM
manojgupta added a comment.Oct 28 2021, 8:24 AM

@kcc do you have any concerns?

manojgupta added a reviewer: morehouse.Nov 17 2021, 9:07 PM

Matt, do you think you can review this?

morehouse accepted this revision.Nov 18 2021, 6:48 AM

LGTM

This revision is now accepted and ready to land.Nov 18 2021, 6:48 AM
Closed by commit rG2782cb8da0b3: libfuzzer: All building libfuzzer for ARM32 (authored by manojgupta). · Explain WhyNov 18 2021, 5:31 PM
This revision was automatically updated to reflect the committed changes.
manojgupta added a commit: rG2782cb8da0b3: libfuzzer: All building libfuzzer for ARM32.
manojgupta mentioned this in D114312: libfuzzer: Disable broken tests for arm.Nov 19 2021, 10:11 PM
manojgupta mentioned this in rG2e67276d984d: libfuzzer: Disable broken tests for arm.Nov 22 2021, 10:33 AM
DavidSpickett added a subscriber: DavidSpickett.EditedDec 7 2021, 3:23 AM

Since this change we've had check-2 timeouts on our 2 stage v7 bots https://lab.llvm.org/buildbot/#/builders/190/builds/513 (we have one building thumb and one Arm)

I see you already disabled some tests so I'm going to see if I can find the specific tests that are hanging and do the same.

DavidSpickett added a comment.Dec 7 2021, 4:03 AM

Done in https://reviews.llvm.org/rG6bfbb89e96fa.

Revision Contents

PathSize
compiler-rt/
cmake/
Modules/
2 lines

Diff 388358

compiler-rt/cmake/Modules/AllSupportedArchDefs.cmake

Show All 32 Lines
if(ANDROID) if(ANDROID)
set(OS_NAME "Android") set(OS_NAME "Android")
else() else()
set(OS_NAME "${CMAKE_SYSTEM_NAME}") set(OS_NAME "${CMAKE_SYSTEM_NAME}")
endif() endif()
if(OS_NAME MATCHES "Linux") if(OS_NAME MATCHES "Linux")
set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM64} ${S390X}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64} ${S390X})
elseif (OS_NAME MATCHES "Windows") elseif (OS_NAME MATCHES "Windows")
set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64})
elseif(OS_NAME MATCHES "Android") elseif(OS_NAME MATCHES "Android")
set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86} ${X86_64} ${ARM32} ${ARM64})
else() else()
set(ALL_FUZZER_SUPPORTED_ARCH ${X86_64} ${ARM64}) set(ALL_FUZZER_SUPPORTED_ARCH ${X86_64} ${ARM64})
endif() endif()
Show All 33 Lines