Page MenuHomePhabricator

[AMDGPU] Fix width check for signed mul24 generation.
ClosedPublic

Authored by abinavpp on Oct 14 2021, 10:23 AM.

Details

Summary

This changes fixes a case in which the highest set bit of the original
result is at bit 31 and sign-extending the mul24 for it would make the
result negative.

Diff Detail

Event Timeline

abinavpp created this revision.Oct 14 2021, 10:23 AM
abinavpp requested review of this revision.Oct 14 2021, 10:23 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 14 2021, 10:23 AM
abinavpp updated this revision to Diff 379760.Oct 14 2021, 10:28 AM

Reword comments.

foad accepted this revision.Oct 15 2021, 1:58 AM
This revision is now accepted and ready to land.Oct 15 2021, 1:58 AM
This revision was automatically updated to reflect the committed changes.