[mlir] Fix tsan failure in PassCrashRecovery

[rriddle]

Summary

Don't set printOpOnDiagnostic, as this is not safe to call from a threaded context.

[rriddle]

This is simple enough so just pushing directly.

mlir/lib/Pass/PassCrashRecovery.cpp

void RecoveryReproducerContext::crashHandler(void *) {
   // Walk the current stack of contexts and generate a reproducer for each one.
   // We can't know for certain which one was the cause, so we need to generate
   // a reproducer for all of them.
   for (RecoveryReproducerContext *context : *reproducerSet) {
     std::string description;
     context->generate(description);
 
     // Emit an error using information only available within the context.
-    context->preCrashOperation->getContext()->printOpOnDiagnostic(false);
-    context->preCrashOperation->emitError()
+    emitError(context->preCrashOperation->getLoc())
         << "A failure has been detected while processing the MLIR module:"
         << description;
   }
 }
 
 void RecoveryReproducerContext::registerSignalHandler() {
   // Ensure that the handler is only registered once.
   static bool registered =
void PassCrashReproducerGenerator::finalize(Operation *rootOp,
   // Don't generate a reproducer if we have no active contexts.
   if (impl->activeContexts.empty())
     return;
 
   // If the pass manager execution succeeded, we don't generate any reproducers.
   if (succeeded(executionResult))
     return impl->activeContexts.clear();
 
-  MLIRContext *context = rootOp->getContext();
-  bool shouldPrintOnOp = context->shouldPrintOpOnDiagnostic();
-  context->printOpOnDiagnostic(false);
-  InFlightDiagnostic diag = rootOp->emitError()
+  InFlightDiagnostic diag = emitError(rootOp->getLoc())
                             << "Failures have been detected while "
                                "processing an MLIR pass pipeline";
-  context->printOpOnDiagnostic(shouldPrintOnOp);
 
   // If we are generating a global reproducer, we include all of the running
   // passes in the error message for the only active context.
   if (!impl->localReproducer) {
     assert(impl->activeContexts.size() == 1 && "expected one active context");
 
     // Generate the reproducer.
     std::string description;