This is an archive of the discontinued LLVM Phabricator instance.

Differential D111737

[AMDGPU] Remove unneeded emit literal check
ClosedPublic

Authored by Joe_Nash on Oct 13 2021, 8:51 AM.

Details

Reviewers
rampitec
foad
Commits
rGb44eac1b851a: [AMDGPU] Remove unneeded emit literal check
Summary

NFC. This check does not verify any functional property since size 8
was added. Remove it for simplicity.

Diff Detail

Event Timeline

Joe_Nash created this revision.Oct 13 2021, 8:51 AM
Herald added subscribers: kerbowa, hiraditya, t-tye and 7 others. · View Herald TranscriptOct 13 2021, 8:51 AM
Joe_Nash requested review of this revision.Oct 13 2021, 8:51 AM
Herald added a project: Restricted Project. · View Herald TranscriptOct 13 2021, 8:51 AM
Herald added subscribers: llvm-commits, wdng. · View Herald Transcript
rampitec accepted this revision.Oct 13 2021, 9:51 AM

LGTM

This revision is now accepted and ready to land.Oct 13 2021, 9:51 AM
Harbormaster completed remote builds in B128650: Diff 379423.Oct 13 2021, 10:01 AM
Closed by commit rGb44eac1b851a: [AMDGPU] Remove unneeded emit literal check (authored by Joe_Nash). · Explain WhyOct 13 2021, 10:04 AM
This revision was automatically updated to reflect the committed changes.
Joe_Nash added a commit: rGb44eac1b851a: [AMDGPU] Remove unneeded emit literal check.

Revision Contents

PathSize
llvm/
lib/
Target/
AMDGPU/
MCTargetDesc/
3 lines

Diff 379446

llvm/lib/Target/AMDGPU/MCTargetDesc/SIMCCodeEmitter.cpp

Show First 20 Lines • Show All 541 Lines • ▼ Show 20 Linesuint64_t SIMCCodeEmitter::getMachineOpValue(const MCInst &MI,
for (unsigned e = MI.getNumOperands(); OpNo < e; ++OpNo) { for (unsigned e = MI.getNumOperands(); OpNo < e; ++OpNo) {
if (&MO == &MI.getOperand(OpNo)) if (&MO == &MI.getOperand(OpNo))
break; break;
} }
const MCInstrDesc &Desc = MCII.get(MI.getOpcode()); const MCInstrDesc &Desc = MCII.get(MI.getOpcode());
if (AMDGPU::isSISrcOperand(Desc, OpNo)) { if (AMDGPU::isSISrcOperand(Desc, OpNo)) {
uint32_t Enc = getLitEncoding(MO, Desc.OpInfo[OpNo], STI); uint32_t Enc = getLitEncoding(MO, Desc.OpInfo[OpNo], STI);
if (Enc != ~0U && if (Enc != ~0U)
(Enc != 255 || Desc.getSize() == 4 || Desc.getSize() == 8))
return Enc; return Enc;
} else if (MO.isImm()) } else if (MO.isImm())
return MO.getImm(); return MO.getImm();
llvm_unreachable("Encoding of this operand type is not supported yet."); llvm_unreachable("Encoding of this operand type is not supported yet.");
return 0; return 0;
} }
#define ENABLE_INSTR_PREDICATE_VERIFIER #define ENABLE_INSTR_PREDICATE_VERIFIER
#include "AMDGPUGenMCCodeEmitter.inc" #include "AMDGPUGenMCCodeEmitter.inc"