[llvm-readelf] Make -W an alias of --wide

[gbreynoo]

Summary

Currently -W and --wide are treated as two options as they are only included for gnu readelf compatibility and ignored. This change makes -W an alias of --wide to be consistent with other option aliases.

[MaskRay]

Does this change --help output? If not, seems unnecessary?

[jhenderson]

In D111731#3061846, @MaskRay wrote:

Does this change --help output? If not, seems unnecessary?

We've got some downstream code that intends to iterate over all possibly specified options, regardless of their eventual impact on the behaviour of the tool. Without this change, the "W" and "wide" options would appear as separate entries, unlike other aliases, which is not desirable.

Plus, as @gbreynoo pointed out, this ensures consistency - in llvm-objdump the same options are aliases, rather than separate options.

[gbreynoo]

Just to confirm, this does not change the help output.

llvm/tools/llvm-readobj/Opts.td

 def coff_load_config : FF<"coff-load-config", "Display load config">, Group<grp_coff>;
 def coff_resources : FF<"coff-resources", "Display .rsrc section">, Group<grp_coff>;
 def coff_tls_directory : FF<"coff-tls-directory", "Display TLS directory">, Group<grp_coff>;
 
 def help : FF<"help", "Display this help">;
 def version : FF<"version", "Display the version">;
 
 // Ignored for GNU readelf compatibility.
-def : F<"W", "Ignored for GNU readelf compatibility">;
-def : FF<"wide", "Ignored for GNU readelf compatibility">;
+def wide : FF<"wide", "Ignored for GNU readelf compatibility">;
+def : F<"W", "Ignored for GNU readelf compatibility">, Alias<wide>;
 
 // Traditional llvm-readobj Aliases.
 def : Flag<["--"], "dt">, Alias<dyn_syms>, HelpText<"Alias for --dyn-syms">;
 def : Flag<["--"], "sd">, Alias<section_data>, HelpText<"Alias for --section-data">;
 def : Flag<["--"], "st">, Alias<section_symbols>, HelpText<"Alias for --section-symbols">;
 def : Flag<["--"], "sr">, Alias<section_relocations>, HelpText<"Alias for --section-relocations">;
 
 // Aliases.