Page MenuHomePhabricator
Differential D111498

[lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected
ClosedPublic
Actions

Authored by mgorny on Oct 9 2021, 12:25 PM.

Details

Reviewers
labath
teemperor
krytarowski
emaste
Commits
rG1bd258fd4e2c: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected
Summary

(note that this assumes parent diffs are merged)

Now that AddRegister() is no longer used, remove it. While at it,
we can also make Finalize() protected as all supported API methods
call it internally.

Diff Detail

Event Timeline

mgorny requested review of this revision.Oct 9 2021, 12:25 PM
mgorny created this revision.
mgorny added parent revisions: D111491: [lldb] [gdb-remote] Remove HardcodeARMRegisters() hack, D111435: [lldb] [DynamicRegisterInfo] Support setting from vector<Register>.
Harbormaster completed remote builds in B127955: Diff 378469.Oct 9 2021, 12:26 PM
labath accepted this revision.Oct 11 2021, 4:24 AM

LGTM (assuming parent diffs are merged) :P

This revision is now accepted and ready to land.Oct 11 2021, 4:24 AM
This revision was landed with ongoing or failed builds.Oct 25 2021, 11:06 AM
Closed by commit rG1bd258fd4e2c: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected (authored by mgorny). · Explain Why
This revision was automatically updated to reflect the committed changes.
mgorny added a commit: rG1bd258fd4e2c: [lldb] [DynamicRegisterInfo] Remove AddRegister() and make Finalize() protected.
Herald added a project: Restricted Project. · View Herald TranscriptOct 25 2021, 11:06 AM

Revision Contents
Changeset List

PathSize
lldb/
include/
lldb/
Target/
7 lines
source/
Target/
29 lines
unittests/
Target/
102 lines

Diff 382059

View Options

lldb/include/lldb/Target/DynamicRegisterInfo.h

Loading...
View Options

lldb/source/Target/DynamicRegisterInfo.cpp

Loading...
View Options

lldb/unittests/Target/DynamicRegisterInfoTest.cpp

Loading...