This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Skip AllocAfterFork test on machines with low max_map_count
ClosedPublic

Authored by cryptoad on Oct 8 2021, 2:16 PM.

Details

Summary

Reducing the number of iterations in that test with D111342 helped,
but the failure still occured flakily when the test is ran as part
of a large test suite.

Reducing further the number of iterations might not be good enough,
so we will skip the test if the max_map_count variable can be
read, and if lower than a given threshold.

Diff Detail

Event Timeline

cryptoad requested review of this revision.Oct 8 2021, 2:16 PM
cryptoad created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 2:16 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
cryptoad updated this revision to Diff 378359.Oct 8 2021, 2:16 PM

... and remove local debugging line.

leonardchan accepted this revision.Oct 8 2021, 2:28 PM

LGTM Thanks again for looking into this.

This revision is now accepted and ready to land.Oct 8 2021, 2:28 PM