This is an archive of the discontinued LLVM Phabricator instance.

Differential D111427

[AIX] Ignore case when comparing output from od
ClosedPublic

Authored by Kai on Oct 8 2021, 8:37 AM.

Details

Reviewers
daltenty
Esme
sfertile
abhina.sreeskantharajan
kbarton
Commits
rGb050564d3e93: [AIX] Ignore case when comparing output from od
Summary

POSIX does not define the exact output from od tool.
While most implementations use lower case characters in hex output,
the z/OS USS implementation uses upper case characters.
To avoid LIT failures, the FileCheck option to ignore the case must
be used when checking hex bytes.

Diff Detail

Event Timeline

Kai requested review of this revision.Oct 8 2021, 8:37 AM
Kai created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 8 2021, 8:37 AM
Herald added a subscriber: llvm-commits. · View Herald Transcript
Harbormaster completed remote builds in B127788: Diff 378241.Oct 8 2021, 9:20 AM
abhina.sreeskantharajan accepted this revision.Oct 8 2021, 10:07 AM

LGTM

This revision is now accepted and ready to land.Oct 8 2021, 10:07 AM
This revision was landed with ongoing or failed builds.Oct 14 2021, 10:52 AM
Closed by commit rGb050564d3e93: [AIX] Ignore case when comparing output from od (authored by Kai). · Explain Why
This revision was automatically updated to reflect the committed changes.
Kai added a commit: rGb050564d3e93: [AIX] Ignore case when comparing output from od.

Revision Contents

PathSize
llvm/
test/
tools/
yaml2obj/
XCOFF/
3 lines

Diff 379773

llvm/test/tools/yaml2obj/XCOFF/string-table.yaml

Show First 20 Lines • Show All 279 Lines • ▼ Show 20 Lines
# RUN: not yaml2obj --docnum=2 %s -DRAWCONTENT="0062006300" -o %t18 2>&1 \ # RUN: not yaml2obj --docnum=2 %s -DRAWCONTENT="0062006300" -o %t18 2>&1 \
# RUN: | FileCheck %s --check-prefix=CASE18 # RUN: | FileCheck %s --check-prefix=CASE18
# CASE18: error: can't specify Strings or Length when RawContent is specified # CASE18: error: can't specify Strings or Length when RawContent is specified
## Case 19: use the value of the `Length` field for the first 4 bytes of the ## Case 19: use the value of the `Length` field for the first 4 bytes of the
## table. We dump the string table from the offset of 0x38. ## table. We dump the string table from the offset of 0x38.
# RUN: yaml2obj --docnum=1 %s -DSYMNAME='nameInStrTbl' -DLENGTHVALUE=20 -o %t19 # RUN: yaml2obj --docnum=1 %s -DSYMNAME='nameInStrTbl' -DLENGTHVALUE=20 -o %t19
# RUN: od -A n -t x1 -v -j 0x38 %t19 | FileCheck %s --check-prefix=CASE19 # RUN: od -A n -t x1 -v -j 0x38 %t19 \
# RUN: | FileCheck %s --ignore-case --check-prefix=CASE19
# CASE19: 00 00 00 14 6e 61 6d 65 49 6e 53 74 72 54 62 6c # CASE19: 00 00 00 14 6e 61 6d 65 49 6e 53 74 72 54 62 6c
# CASE19-NEXT: 00 # CASE19-NEXT: 00