This is an archive of the discontinued LLVM Phabricator instance.

[lldb] [DynamicRegisterInfo] Remove non-const GetRegisterInfoAtIndex()
ClosedPublic

Authored by mgorny on Oct 8 2021, 7:27 AM.

Reviewers

Commits

mgorny requested review of this revision.Oct 8 2021, 7:27 AM

cool

This revision is now accepted and ready to land.Oct 11 2021, 2:42 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

lldb/

include/

lldb/

Target/

2 lines

source/

Target/

6 lines

Show First 20 Lines • Show All 49 Lines • ▼ Show 20 Lines	public:
size_t GetNumRegisters() const;		size_t GetNumRegisters() const;

size_t GetNumRegisterSets() const;		size_t GetNumRegisterSets() const;

size_t GetRegisterDataByteSize() const;		size_t GetRegisterDataByteSize() const;

const lldb_private::RegisterInfo *GetRegisterInfoAtIndex(uint32_t i) const;		const lldb_private::RegisterInfo *GetRegisterInfoAtIndex(uint32_t i) const;

lldb_private::RegisterInfo *GetRegisterInfoAtIndex(uint32_t i);

const lldb_private::RegisterSet *GetRegisterSet(uint32_t i) const;		const lldb_private::RegisterSet *GetRegisterSet(uint32_t i) const;

uint32_t GetRegisterSetIndexByName(lldb_private::ConstString &set_name,		uint32_t GetRegisterSetIndexByName(lldb_private::ConstString &set_name,
bool can_create);		bool can_create);

uint32_t ConvertRegisterKindToRegisterNumber(uint32_t kind,		uint32_t ConvertRegisterKindToRegisterNumber(uint32_t kind,
uint32_t num) const;		uint32_t num) const;

▲ Show 20 Lines • Show All 56 Lines • Show Last 20 Lines

	Show First 20 Lines • Show All 685 Lines • ▼ Show 20 Lines

	const RegisterInfo *			const RegisterInfo *
	DynamicRegisterInfo::GetRegisterInfoAtIndex(uint32_t i) const {			DynamicRegisterInfo::GetRegisterInfoAtIndex(uint32_t i) const {
	if (i < m_regs.size())			if (i < m_regs.size())
	return &m_regs[i];			return &m_regs[i];
	return nullptr;			return nullptr;
	}			}

	RegisterInfo *DynamicRegisterInfo::GetRegisterInfoAtIndex(uint32_t i) {
	if (i < m_regs.size())
	return &m_regs[i];
	return nullptr;
	}

	const RegisterInfo *DynamicRegisterInfo::GetRegisterInfo(uint32_t kind,			const RegisterInfo *DynamicRegisterInfo::GetRegisterInfo(uint32_t kind,
	uint32_t num) const {			uint32_t num) const {
	uint32_t reg_index = ConvertRegisterKindToRegisterNumber(kind, num);			uint32_t reg_index = ConvertRegisterKindToRegisterNumber(kind, num);
	if (reg_index != LLDB_INVALID_REGNUM)			if (reg_index != LLDB_INVALID_REGNUM)
	return &m_regs[reg_index];			return &m_regs[reg_index];
	return nullptr;			return nullptr;
	}			}

	▲ Show 20 Lines • Show All 103 Lines • Show Last 20 Lines