This is an archive of the discontinued LLVM Phabricator instance.

Fix test-rsqrt.mlir to accept AMD's approximation of rsqrt as well
ClosedPublic

Authored by mehdi_amini on Oct 7 2021, 6:23 PM.

Details

Summary

These kind of function can behave differently on these X86 chips, there
isn't really "one true answer" so we'll accept both.

Diff Detail

Event Timeline

mehdi_amini created this revision.Oct 7 2021, 6:23 PM
mehdi_amini requested review of this revision.Oct 7 2021, 6:23 PM
cota accepted this revision.Oct 7 2021, 7:10 PM
cota added inline comments.
mlir/test/Integration/Dialect/Vector/CPU/X86Vector/test-rsqrt.mlir
11–12

results

11–12

accept

11–12

results

11–12

produce

This revision is now accepted and ready to land.Oct 7 2021, 7:10 PM