This is an archive of the discontinued LLVM Phabricator instance.

[scudo] Reduce the scope of AllocAfterFork
ClosedPublic

Authored by cryptoad on Oct 7 2021, 12:30 PM.

Details

Summary

ScudoWrappersCppTest.AllocAfterFork was failing obscurely sometimes.
Someone pointed us to Linux's vm.max_map_count that can be
significantly lower on some machines than others. It turned out that
on a machine with that setting set to 65530, some ENOMEM errors
would occur with mmap & mprotect during that specific test.

Reducing the number of times we fork, and the maximum size allocated
during that test makes it pass on those machines.

Diff Detail

Event Timeline

cryptoad requested review of this revision.Oct 7 2021, 12:30 PM
cryptoad created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2021, 12:30 PM
Herald added a subscriber: Restricted Project. · View Herald Transcript
leonardchan accepted this revision.Oct 7 2021, 12:58 PM

LGTM unless others have stuff to bring up.

This revision is now accepted and ready to land.Oct 7 2021, 12:58 PM
hctim accepted this revision.Oct 7 2021, 1:49 PM
This revision was automatically updated to reflect the committed changes.