Page MenuHomePhabricator

[CFE][Codegen] Remove CodeGenFunction::InitTempAlloca()
ClosedPublic

Authored by hsmhsm on Oct 7 2021, 10:12 AM.

Details

Summary

Sequel patch to https://reviews.llvm.org/D111316

Finally, remove the defintion of CodeGenFunction::InitTempAlloca().

Diff Detail

Event Timeline

hsmhsm requested review of this revision.Oct 7 2021, 10:12 AM
hsmhsm created this revision.
Herald added a project: Restricted Project. · View Herald TranscriptOct 7 2021, 10:12 AM

Can you just do one patch for all the OpenMP changes, and then put the final removal in a separate patch?

Thanks for taking this on.

hsmhsm updated this revision to Diff 378094.Oct 7 2021, 10:27 PM

Move OpenMP GPU offloading codegen related changes from here to https://reviews.llvm.org/D111324.

hsmhsm edited the summary of this revision. (Show Details)Oct 7 2021, 10:28 PM
rjmccall accepted this revision.Oct 8 2021, 12:19 PM

Thanks. This LGTM when all the patches it depends on are checked in.

This revision is now accepted and ready to land.Oct 8 2021, 12:19 PM
hsmhsm updated this revision to Diff 378413.Oct 8 2021, 9:52 PM

Rebase.

This revision was automatically updated to reflect the committed changes.